Issue 398573005: Gracefully handle ScriptProcessorNode event processing when detached.

Issue 398573005: Gracefully handle ScriptProcessorNode event processing when detached. (Closed)

Created:
6 years, 5 months ago by sof

Modified:
6 years, 5 months ago

Reviewers:
tkent, haraken, Raymond Toy

CC:
blink-reviews, Raymond Toy

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

Gracefully handle ScriptProcessorNode event processing when detached. Check that we have an ExecutionContext to deliver a process event to before dispatching. R=haraken@chromium.org BUG=394718 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178385

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+64 lines, -2 lines)			Patch
A +	LayoutTests/webaudio/resources/scriptprocessornode-detached-no-crash-new-window.html	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A	LayoutTests/webaudio/scriptprocessornode-detached-no-crash.html	View	1	1 chunk	+61 lines, -0 lines	0 comments	Download
A +	LayoutTests/webaudio/scriptprocessornode-detached-no-crash-expected.txt	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	Source/modules/webaudio/ScriptProcessorNode.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 9 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/398573005/1

6 years, 5 months ago (2014-07-17 15:11:14 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/398573005/20001

6 years, 5 months ago (2014-07-17 15:24:36 UTC) #6

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu on tryserver.chromium.gpu ...

6 years, 5 months ago (2014-07-17 16:42:56 UTC) #7

Message was sent while issue was closed.

Thank you for the fix!!!