Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 398573005: Gracefully handle ScriptProcessorNode event processing when detached. (Closed)

Created:
6 years, 5 months ago by sof
Modified:
6 years, 5 months ago
Reviewers:
tkent, haraken, Raymond Toy
CC:
blink-reviews, Raymond Toy
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Gracefully handle ScriptProcessorNode event processing when detached. Check that we have an ExecutionContext to deliver a process event to before dispatching. R=haraken@chromium.org BUG=394718 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178385

Patch Set 1 #

Patch Set 2 : Tidy test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -2 lines) Patch
A + LayoutTests/webaudio/resources/scriptprocessornode-detached-no-crash-new-window.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A LayoutTests/webaudio/scriptprocessornode-detached-no-crash.html View 1 1 chunk +61 lines, -0 lines 0 comments Download
A + LayoutTests/webaudio/scriptprocessornode-detached-no-crash-expected.txt View 1 chunk +3 lines, -2 lines 0 comments Download
M Source/modules/webaudio/ScriptProcessorNode.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
sof
Please take a look.
6 years, 5 months ago (2014-07-17 14:54:51 UTC) #1
haraken
LGTM. You fix a lot of bugs in an amazing speed...
6 years, 5 months ago (2014-07-17 15:05:26 UTC) #2
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 5 months ago (2014-07-17 15:09:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/398573005/1
6 years, 5 months ago (2014-07-17 15:11:14 UTC) #4
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 5 months ago (2014-07-17 15:24:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/398573005/20001
6 years, 5 months ago (2014-07-17 15:24:36 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu on tryserver.chromium.gpu ...
6 years, 5 months ago (2014-07-17 16:42:56 UTC) #7
commit-bot: I haz the power
Change committed as 178385
6 years, 5 months ago (2014-07-17 17:47:42 UTC) #8
tkent
6 years, 5 months ago (2014-07-17 23:37:39 UTC) #9
Message was sent while issue was closed.
Thank you for the fix!!!

Powered by Google App Engine
This is Rietveld 408576698