Issue 398563002: Do not create a reply IPCMessage for every message received.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 398563002: Do not create a reply IPCMessage for every message received. (Closed)

Created:
6 years, 5 months ago by Robert Sesek

Modified:
6 years, 5 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Do not create a reply IPCMessage for every message received. This is incompatible with the way xpc_dictionary_create_reply() works, which may only be called once per message. This would inhibit forwarding messages, since the receiver of the forwarded XPC message would not be able to reply. Instead, replies now must be created explicitly via MessageServer::CreateReply(). BUG=382931 R=mark@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283376

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+46 lines, -35 lines)			Patch
M	sandbox/mac/launchd_interception_server.h	View	1 chunk	+3 lines, -5 lines	0 comments	Download
M	sandbox/mac/launchd_interception_server.cc	View	6 chunks	+8 lines, -10 lines	0 comments	Download
M	sandbox/mac/mach_message_server.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	sandbox/mac/mach_message_server.cc	View	3 chunks	+22 lines, -12 lines	0 comments	Download
M	sandbox/mac/message_server.h	View	2 chunks	+11 lines, -7 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/398563002/1

6 years, 5 months ago (2014-07-15 21:51:03 UTC) #4

Message was sent while issue was closed.

Change committed as 283376

Expand Messages | Collapse Messages