Issue 398553002: Mojo: Mojom: Add AST types for struct and struct body.

Issue 398553002: Mojo: Mojom: Add AST types for struct and struct body. (Closed)

Created:
6 years, 5 months ago by viettrungluu

Modified:
6 years, 5 months ago

Reviewers:
DaveMoore

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Mojo: Mojom: Add AST types for struct and struct body. R=davemoore@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283436

Patch Set 2 : rebased #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+177 lines, -138 lines)			Patch
M	mojo/public/tools/bindings/pylib/mojom/parse/ast.py	View	3 chunks	+50 lines, -19 lines	0 comments	Download
M	mojo/public/tools/bindings/pylib/mojom/parse/parser.py	View	1 chunk	+13 lines, -10 lines	0 comments	Download
M	mojo/public/tools/bindings/pylib/mojom/parse/translate.py	View	3 chunks	+19 lines, -19 lines	0 comments	Download
M	mojo/public/tools/bindings/pylib/mojom_tests/parse/parser_unittest.py	View	12 chunks	+95 lines, -90 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

DaveMoore

lgtm https://codereview.chromium.org/398553002/diff/1/mojo/public/tools/bindings/pylib/mojom/parse/ast.py File mojo/public/tools/bindings/pylib/mojom/parse/ast.py (right): https://codereview.chromium.org/398553002/diff/1/mojo/public/tools/bindings/pylib/mojom/parse/ast.py#newcode34 mojo/public/tools/bindings/pylib/mojom/parse/ast.py:34: pass Nit: isn't this a noop?

6 years, 5 months ago (2014-07-16 18:07:08 UTC) #2

viettrungluu

Thanks. https://codereview.chromium.org/398553002/diff/1/mojo/public/tools/bindings/pylib/mojom/parse/ast.py File mojo/public/tools/bindings/pylib/mojom/parse/ast.py (right): https://codereview.chromium.org/398553002/diff/1/mojo/public/tools/bindings/pylib/mojom/parse/ast.py#newcode34 mojo/public/tools/bindings/pylib/mojom/parse/ast.py:34: pass On 2014/07/16 18:07:08, DaveMoore wrote: > Nit: ...

6 years, 5 months ago (2014-07-16 18:18:00 UTC) #3

viettrungluu

6 years, 5 months ago (2014-07-16 18:20:27 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r283436 (presubmit successful).

Expand Messages | Collapse Messages