cc/quads/render_pass.h - Issue 398533002: Make DrawQuad constructors public, rm DQ::Create() function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/quads/render_pass.h

Issue 398533002: Make DrawQuad constructors public, rm DQ::Create() function (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: get rid of make_scoped_ptr Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/quads/render_pass.h

diff --git a/cc/quads/render_pass.h b/cc/quads/render_pass.h

index 6b68f8d910b4c4065ef3d53bd1e45ce0be6cf843..3032f050d4c2396e3898e48f3fcae410e217c36e 100644

--- a/cc/quads/render_pass.h

+++ b/cc/quads/render_pass.h

@@ -92,7 +92,7 @@ class CC_EXPORT RenderPass {

SharedQuadState* CreateAndAppendSharedQuadState();

template <typename DrawQuadType>

DrawQuadType* CreateAndAppendDrawQuad() {

- scoped_ptr<DrawQuadType> draw_quad = DrawQuadType::Create();

+ scoped_ptr<DrawQuadType> draw_quad = make_scoped_ptr(new DrawQuadType);

quad_list.push_back(draw_quad.template PassAs<DrawQuad>());

return static_cast<DrawQuadType*>(quad_list.back());

}

« no previous file with comments | « cc/quads/picture_draw_quad.cc ('k') | cc/quads/render_pass_draw_quad.h » ('j') | no next file with comments »