mojo/services/public/cpp/surfaces/lib/surfaces_type_converters.cc - Issue 398533002: Make DrawQuad constructors public, rm DQ::Create() function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/services/public/cpp/surfaces/lib/surfaces_type_converters.cc

Issue 398533002: Make DrawQuad constructors public, rm DQ::Create() function (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: call RenderPass function in mojo Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/examples/surfaces_app/embedder.cc ('k') | mojo/services/public/cpp/surfaces/tests/surface_unittest.cc » ('j') | mojo/services/public/cpp/surfaces/tests/surface_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/services/public/cpp/surfaces/lib/surfaces_type_converters.cc

diff --git a/mojo/services/public/cpp/surfaces/lib/surfaces_type_converters.cc b/mojo/services/public/cpp/surfaces/lib/surfaces_type_converters.cc

index e61ad94df9dedd42df4f7143cffc9f6652505bbb..9be3ceddf30c6c217a89829e0145147e35cc8d72 100644

--- a/mojo/services/public/cpp/surfaces/lib/surfaces_type_converters.cc

+++ b/mojo/services/public/cpp/surfaces/lib/surfaces_type_converters.cc

@@ -114,7 +114,7 @@ scoped_ptr<cc::DrawQuad> ConvertTo(const surfaces::QuadPtr& input,

switch (input->material) {

case surfaces::SOLID_COLOR: {

scoped_ptr<cc::SolidColorDrawQuad> color_quad =

- cc::SolidColorDrawQuad::Create();

+ make_scoped_ptr(new cc::SolidColorDrawQuad);

color_quad->SetAll(

sqs,

input->rect.To<gfx::Rect>(),

@@ -127,7 +127,7 @@ scoped_ptr<cc::DrawQuad> ConvertTo(const surfaces::QuadPtr& input,

}

case surfaces::SURFACE_CONTENT: {

scoped_ptr<cc::SurfaceDrawQuad> surface_quad =

- cc::SurfaceDrawQuad::Create();

+ make_scoped_ptr(new cc::SurfaceDrawQuad);

surface_quad->SetAll(

sqs,

input->rect.To<gfx::Rect>(),

@@ -139,7 +139,7 @@ scoped_ptr<cc::DrawQuad> ConvertTo(const surfaces::QuadPtr& input,

}

case surfaces::TEXTURE_CONTENT: {

scoped_ptr<cc::TextureDrawQuad> texture_quad =

- cc::TextureDrawQuad::Create();

+ make_scoped_ptr(new cc::TextureDrawQuad);

surfaces::TextureQuadStatePtr& texture_quad_state =

input->texture_quad_state;

texture_quad->SetAll(