Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1534)

Side by Side Diff: cc/quads/render_pass.h

Issue 398533002: Make DrawQuad constructors public, rm DQ::Create() function (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: get rid of make_scoped_ptr Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/quads/picture_draw_quad.cc ('k') | cc/quads/render_pass_draw_quad.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 The Chromium Authors. All rights reserved. 1 // Copyright 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CC_QUADS_RENDER_PASS_H_ 5 #ifndef CC_QUADS_RENDER_PASS_H_
6 #define CC_QUADS_RENDER_PASS_H_ 6 #define CC_QUADS_RENDER_PASS_H_
7 7
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
85 const gfx::Rect& output_rect, 85 const gfx::Rect& output_rect,
86 const gfx::Rect& damage_rect, 86 const gfx::Rect& damage_rect,
87 const gfx::Transform& transform_to_root_target, 87 const gfx::Transform& transform_to_root_target,
88 bool has_transparent_background); 88 bool has_transparent_background);
89 89
90 scoped_ptr<base::Value> AsValue() const; 90 scoped_ptr<base::Value> AsValue() const;
91 91
92 SharedQuadState* CreateAndAppendSharedQuadState(); 92 SharedQuadState* CreateAndAppendSharedQuadState();
93 template <typename DrawQuadType> 93 template <typename DrawQuadType>
94 DrawQuadType* CreateAndAppendDrawQuad() { 94 DrawQuadType* CreateAndAppendDrawQuad() {
95 scoped_ptr<DrawQuadType> draw_quad = DrawQuadType::Create(); 95 scoped_ptr<DrawQuadType> draw_quad = make_scoped_ptr(new DrawQuadType);
96 quad_list.push_back(draw_quad.template PassAs<DrawQuad>()); 96 quad_list.push_back(draw_quad.template PassAs<DrawQuad>());
97 return static_cast<DrawQuadType*>(quad_list.back()); 97 return static_cast<DrawQuadType*>(quad_list.back());
98 } 98 }
99 99
100 RenderPassDrawQuad* CopyFromAndAppendRenderPassDrawQuad( 100 RenderPassDrawQuad* CopyFromAndAppendRenderPassDrawQuad(
101 const RenderPassDrawQuad* quad, 101 const RenderPassDrawQuad* quad,
102 const SharedQuadState* shared_quad_state, 102 const SharedQuadState* shared_quad_state,
103 RenderPass::Id render_pass_id); 103 RenderPass::Id render_pass_id);
104 DrawQuad* CopyFromAndAppendDrawQuad(const DrawQuad* quad, 104 DrawQuad* CopyFromAndAppendDrawQuad(const DrawQuad* quad,
105 const SharedQuadState* shared_quad_state); 105 const SharedQuadState* shared_quad_state);
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
161 #error define a hash function for your compiler 161 #error define a hash function for your compiler
162 #endif // COMPILER 162 #endif // COMPILER
163 } // namespace BASE_HASH_NAMESPACE 163 } // namespace BASE_HASH_NAMESPACE
164 164
165 namespace cc { 165 namespace cc {
166 typedef ScopedPtrVector<RenderPass> RenderPassList; 166 typedef ScopedPtrVector<RenderPass> RenderPassList;
167 typedef base::hash_map<RenderPass::Id, RenderPass*> RenderPassIdHashMap; 167 typedef base::hash_map<RenderPass::Id, RenderPass*> RenderPassIdHashMap;
168 } // namespace cc 168 } // namespace cc
169 169
170 #endif // CC_QUADS_RENDER_PASS_H_ 170 #endif // CC_QUADS_RENDER_PASS_H_
OLDNEW
« no previous file with comments | « cc/quads/picture_draw_quad.cc ('k') | cc/quads/render_pass_draw_quad.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698