Issue 398523002: Reland: Don't treat first touch move differently from future touch moves

Issue 398523002: Reland: Don't treat first touch move differently from future touch moves (Closed)

Created:
6 years, 5 months ago by tdresser

Modified:
6 years, 5 months ago

Reviewers:
jdduke (slow)

CC:
chromium-reviews, ben+aura_chromium.org, tdresser+watch_chromium.org, jam, sadrul, darin-cc_chromium.org, kalyank, jdduke+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Reland: Don't treat first touch move differently from future touch moves Don't treat first move touch differently from future touch moves. See http://lists.w3.org/Archives/Public/public-touchevents/2014Apr/0005.html for details. Originally landed here: https://codereview.chromium.org/228973003/ Reverted here: https://codereview.chromium.org/394523004/ because it caused https://code.google.com/p/chromium/issues/detail?id=393695 BUG=354460 TEST=TouchEventQueueTest.TouchAbsorptionWithConsumedFirstMove, TouchEventQueueTest.TouchCancelOnScroll Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283360

Patch Set 3 : Remove seen_scroll_update_this_sequence_. #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+181 lines, -53 lines)			Patch
M	content/browser/renderer_host/input/touch_event_queue.cc	View	1 2	2 chunks	+25 lines, -20 lines	0 comments	Download
M	content/browser/renderer_host/input/touch_event_queue_unittest.cc	View	1	10 chunks	+91 lines, -10 lines	0 comments	Download
M	ui/aura/gestures/gesture_recognizer_unittest.cc	View		8 chunks	+55 lines, -16 lines	0 comments	Download
M	ui/events/gesture_detection/touch_disposition_gesture_filter.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/events/gesture_detection/touch_disposition_gesture_filter_unittest.cc	View		2 chunks	+9 lines, -6 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

tdresser

Can you take a look? The trybots appear to be a little sad currently - ...

6 years, 5 months ago (2014-07-15 18:28:19 UTC) #1

jdduke (slow)

I assume the test changes fail without the |seen_scroll_update_this_sequence_ = true;| assignment? lgtm. https://codereview.chromium.org/398523002/diff/20001/content/browser/renderer_host/input/touch_event_queue.cc File ...

6 years, 5 months ago (2014-07-15 18:54:47 UTC) #2

tdresser

https://codereview.chromium.org/398523002/diff/20001/content/browser/renderer_host/input/touch_event_queue.cc File content/browser/renderer_host/input/touch_event_queue.cc (right): https://codereview.chromium.org/398523002/diff/20001/content/browser/renderer_host/input/touch_event_queue.cc#newcode577 content/browser/renderer_host/input/touch_event_queue.cc:577: send_touch_events_async_ = true; On 2014/07/15 18:54:47, jdduke wrote: > ...

6 years, 5 months ago (2014-07-15 20:36:49 UTC) #3

jdduke (slow)

On 2014/07/15 20:36:49, tdresser wrote: > https://codereview.chromium.org/398523002/diff/20001/content/browser/renderer_host/input/touch_event_queue.cc > File content/browser/renderer_host/input/touch_event_queue.cc (right): > > https://codereview.chromium.org/398523002/diff/20001/content/browser/renderer_host/input/touch_event_queue.cc#newcode577 > ...

6 years, 5 months ago (2014-07-15 20:45:14 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tdresser@chromium.org/398523002/40001

6 years, 5 months ago (2014-07-15 20:48:19 UTC) #6

Message was sent while issue was closed.

Change committed as 283360

Expand Messages | Collapse Messages