Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 398483005: Add --resetGpuContext to both DM and nanobench. (Closed)

Created:
6 years, 5 months ago by mtklein_C
Modified:
6 years, 5 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Add --resetGpuContext to both DM and nanobench. Defaulting to true to be conservative for now. BUG=skia: NOTREECHECKS=true Committed: https://skia.googlesource.com/skia/+/1e319f734275b166fefe121ac9f4783ab70bc03b

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M bench/nanobench.cpp View 2 chunks +5 lines, -0 lines 0 comments Download
M dm/DMGpuSupport.h View 1 chunk +1 line, -0 lines 0 comments Download
M dm/DMTask.cpp View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
mtklein
lgtm
6 years, 5 months ago (2014-07-15 15:13:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/398483005/20001
6 years, 5 months ago (2014-07-15 15:13:14 UTC) #2
mtklein
The CQ bit was unchecked by mtklein@google.com
6 years, 5 months ago (2014-07-15 15:19:16 UTC) #3
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 5 months ago (2014-07-15 15:19:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/398483005/20001
6 years, 5 months ago (2014-07-15 15:19:25 UTC) #5
mtklein
The CQ bit was unchecked by mtklein@google.com
6 years, 5 months ago (2014-07-15 15:23:51 UTC) #6
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 5 months ago (2014-07-15 15:23:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/398483005/20001
6 years, 5 months ago (2014-07-15 15:23:55 UTC) #8
commit-bot: I haz the power
6 years, 5 months ago (2014-07-15 15:27:10 UTC) #9
Message was sent while issue was closed.
Change committed as 1e319f734275b166fefe121ac9f4783ab70bc03b

Powered by Google App Engine
This is Rietveld 408576698