Issue 398463002: Chromium no longer needs the SkPicture default constructor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 398463002: Chromium no longer needs the SkPicture default constructor (Closed)

Created:
6 years, 5 months ago by robertphillips

Modified:
6 years, 5 months ago

Reviewers:
hal.canary

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Chromium no longer needs the SkPicture default constructor With the landing of the Chromium CL (Remove use of default SkPicture constructor - https://codereview.chromium.org/387343003/) Chromium should no longer require the SK_SUPPORT_LEGACY_DEFAULT_PICTURE_CTOR flag. Committed: https://skia.googlesource.com/skia/+/b6638bddcdacfd1115f1406877a4144df6415d2f

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	gyp/skia_for_chromium_defines.gypi	View		1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 6 (0 generated)

robertphillips

The CQ bit was checked by robertphillips@google.com

6 years, 5 months ago (2014-07-16 13:41:04 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/398463002/1

6 years, 5 months ago (2014-07-16 13:41:40 UTC) #5

commit-bot: I haz the power

6 years, 5 months ago (2014-07-16 20:21:26 UTC) #6

Message was sent while issue was closed.

Change committed as b6638bddcdacfd1115f1406877a4144df6415d2f