Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(661)

Issue 398453002: Add dummy BUILDER object to java interfaces. (Closed)

Created:
6 years, 5 months ago by qsr
Modified:
6 years, 5 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

Add dummy BUILDER object to java interfaces. BUILDER object are needed to correctly encode interfaces. Add a dummy object until the real interfaces are pushed to allow using interfaces in structs. BUG=392693 TBR=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283258

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M mojo/public/tools/bindings/generators/java_templates/interface_definition.tmpl View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
qsr
6 years, 5 months ago (2014-07-15 09:26:10 UTC) #1
qsr
The CQ bit was checked by qsr@chromium.org
6 years, 5 months ago (2014-07-15 09:26:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/398453002/1
6 years, 5 months ago (2014-07-15 09:29:25 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-15 19:26:17 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-15 19:59:25 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/170787)
6 years, 5 months ago (2014-07-15 19:59:26 UTC) #6
darin (slow to review)
6 years, 5 months ago (2014-07-15 22:05:48 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 manually as r283258 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698