Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Unified Diff: components/components_tests.gyp

Issue 398423007: Add initial components unit tests to GN build. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/components_tests.gyp
diff --git a/components/components_tests.gyp b/components/components_tests.gyp
index 242356c73b09b0f4568f129454dcc2a19070467e..f2c6b9e389e481bdbf27883754a0aa9349efb417 100644
--- a/components/components_tests.gyp
+++ b/components/components_tests.gyp
@@ -14,9 +14,13 @@
['android_webview_build == 0', {
'targets': [
{
+ # GN version: //components/components_unittests
'target_name': 'components_unittests',
'type': '<(gtest_target_type)',
'sources': [
+ # Note: sources list duplicated in GN build. In the GN build,
+ # each component has its own unit tests target defined in its
+ # directory that are then linked into the final content_unittests.
'auto_login_parser/auto_login_parser_unittest.cc',
'autocomplete/autocomplete_input_unittest.cc',
'autofill/content/browser/content_autofill_driver_unittest.cc',
@@ -64,6 +68,7 @@
'autofill/core/common/form_field_data_unittest.cc',
'autofill/core/common/password_form_fill_data_unittest.cc',
'autofill/core/common/save_password_progress_logger_unittest.cc',
+ # Note: GN tests converted to here, need to do the rest.
'bookmarks/browser/bookmark_codec_unittest.cc',
'bookmarks/browser/bookmark_expanded_state_tracker_unittest.cc',
'bookmarks/browser/bookmark_index_unittest.cc',
« components/autofill/core/common/BUILD.gn ('K') | « components/autofill/core/common/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698