Issue 398423007: Add initial components unit tests to GN build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 398423007: Add initial components unit tests to GN build. (Closed)

Created:
6 years, 5 months ago by brettw

Modified:
6 years, 5 months ago

Reviewers:
DaleCurtis

CC:
chromium-reviews, benquan, jam, browser-components-watch_chromium.org, darin-cc_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Add initial components unit tests to GN build. R=dalecurtis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284178

Patch Set 1 #

Total comments: 1

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+151 lines, -5 lines)			Patch
M	components/BUILD.gn	View	1 chunk	+29 lines, -5 lines	0 comments	Download
M	components/auto_login_parser/BUILD.gn	View	1 chunk	+11 lines, -0 lines	0 comments	Download
M	components/autocomplete/BUILD.gn	View	2 chunks	+16 lines, -0 lines	0 comments	Download
M	components/autofill/content/browser/BUILD.gn	View	2 chunks	+25 lines, -0 lines	0 comments	Download
M	components/autofill/core/browser/BUILD.gn	View	1 chunk	+50 lines, -0 lines	0 comments	Download
M	components/autofill/core/common/BUILD.gn	View	1 chunk	+15 lines, -0 lines	1 comment	Download
M	components/components_tests.gyp	View	2 chunks	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

DaleCurtis

lgtm https://codereview.chromium.org/398423007/diff/1/components/autofill/core/common/BUILD.gn File components/autofill/core/common/BUILD.gn (right): https://codereview.chromium.org/398423007/diff/1/components/autofill/core/common/BUILD.gn#newcode62 components/autofill/core/common/BUILD.gn:62: "save_password_progress_logger_unittest.cc" , for consistency.

6 years, 5 months ago (2014-07-18 18:01:21 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r284178.

Expand Messages | Collapse Messages