Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Unified Diff: LayoutTests/inspector-protocol/css/media-query-listener-exception.html

Issue 398413002: Make media-query-listener-exception.html unflaky. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: review comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/inspector-protocol/css/media-query-listener-exception.html
diff --git a/LayoutTests/inspector-protocol/css/media-query-listener-exception.html b/LayoutTests/inspector-protocol/css/media-query-listener-exception.html
index 9595581d02c845eb6fcface18794db85cabdbec4..ed1b736f1b45eb1c535019d8814a670d9081ea7f 100644
--- a/LayoutTests/inspector-protocol/css/media-query-listener-exception.html
+++ b/LayoutTests/inspector-protocol/css/media-query-listener-exception.html
@@ -9,18 +9,33 @@ if (window.testRunner) {
var theMediaQueryList = window.matchMedia("print");
+var callCount = 0;
theMediaQueryList.addListener(function(aMediaQueryList) {
+ ++callCount;
+ if (callCount == 1) {
+ // This needs to use setTimeout because we want to test
+ // uncaught exceptions.
+ setTimeout("evaluateInFrontend('InspectorTest.sendPageDisable()')", 0);
+ }
+ if (callCount == 2) {
+ // This needs to use setTimeout because we want to test
+ // uncaught exceptions.
+ setTimeout("evaluateInFrontend('InspectorTest.completeTest()')", 0);
+ }
objectThatDoesNotExist.produceError();
});
function test()
{
+ InspectorTest.sendPageDisable = function()
+ {
+ InspectorTest.sendCommand("Page.disable", {});
+ }
+
function didSetEmulatedMedia(messageObject)
{
if (messageObject.error)
InspectorTest.log("FAILED: " + messageObject.error.message);
- InspectorTest.sendCommand("Page.disable", {});
- setTimeout("InspectorTest.completeTest();", 20);
}
InspectorTest.sendCommand("Page.enable", {});
« no previous file with comments | « LayoutTests/TestExpectations ('k') | LayoutTests/inspector-protocol/css/media-query-listener-exception-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698