Issue 398413002: Make media-query-listener-exception.html unflaky.

Issue 398413002: Make media-query-listener-exception.html unflaky. (Closed)

Created:
6 years, 5 months ago by cbiesinger

Modified:
6 years, 5 months ago

Reviewers:
yurys

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, Yoav Weiss

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Make media-query-listener-exception.html unflaky. https://codereview.chromium.org/337883003/ accidentally made this test flaky. Fix this by calling finish from the event listener. BUG=390445 R=yurys@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178497

Patch Set 1 #

Patch Set 2 : try #2 #

Total comments: 4

Patch Set 3 : review comments #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -16 lines)			Patch
M	LayoutTests/FlakyTests	View	1 2	1 chunk	+0 lines, -11 lines	0 comments	Download
M	LayoutTests/TestExpectations	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	LayoutTests/inspector-protocol/css/media-query-listener-exception.html	View	1 2	1 chunk	+17 lines, -2 lines	0 comments	Download
M	LayoutTests/inspector-protocol/css/media-query-listener-exception-expected.txt	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

yurys

LGTM with comments. https://codereview.chromium.org/398413002/diff/20001/LayoutTests/inspector-protocol/css/media-query-listener-exception.html File LayoutTests/inspector-protocol/css/media-query-listener-exception.html (right): https://codereview.chromium.org/398413002/diff/20001/LayoutTests/inspector-protocol/css/media-query-listener-exception.html#newcode30 LayoutTests/inspector-protocol/css/media-query-listener-exception.html:30: function disablePage() We use InspectorTest instead ...

6 years, 5 months ago (2014-07-18 08:50:03 UTC) #2

cbiesinger

Thanks for the review. Comments addressed, going to put this in the cq now. https://codereview.chromium.org/398413002/diff/20001/LayoutTests/inspector-protocol/css/media-query-listener-exception.html ...

6 years, 5 months ago (2014-07-18 22:28:32 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cbiesinger@chromium.org/398413002/40001

6 years, 5 months ago (2014-07-18 22:29:39 UTC) #5

yurys

6 years, 5 months ago (2014-07-21 06:04:28 UTC) #7

Message was sent while issue was closed.

On 2014/07/18 22:28:32, cbiesinger wrote:
> 
> (Is there a web page describing how inspector tests work? I did not find one,
> though admittedly I did not look that hard)
> 
I'm not aware of such page but you can always ask people on DevTools team.
Almost all of the tests have been added by DevTools team so we just didn't need
such page.

Expand Messages | Collapse Messages