Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(727)

Unified Diff: remoting/webapp/fullscreen_v2.js

Issue 398403002: Check isActive in onRestore to work-around crbug.com/394819. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/webapp/fullscreen_v2.js
diff --git a/remoting/webapp/fullscreen_v2.js b/remoting/webapp/fullscreen_v2.js
index 3aaaab16f3006b4543de81343e387385df7bea85..008511e7539e74a2381d7374390b781075cfa3ac 100644
--- a/remoting/webapp/fullscreen_v2.js
+++ b/remoting/webapp/fullscreen_v2.js
@@ -112,6 +112,14 @@ remoting.FullscreenAppsV2.prototype.onMaximized_ = function() {
};
remoting.FullscreenAppsV2.prototype.onRestored_ = function() {
+ // TODO(jamiewalch): ChromeOS generates a spurious onRestore event if
+ // fullscreen() is called from an onMaximized handler (crbug.com/394819),
+ // so test the full-screen status to make sure that this callback is
Wez 2014/07/17 18:49:42 nit: Clarify what you mean by this; i.e. what you
Jamie 2014/07/17 21:36:44 Done.
+ // genuine.
+ if (this.isActive()) {
+ return;
+ }
+
document.body.classList.remove('fullscreen');
if (this.hookingWindowEvents_) {
this.activate(false);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698