Check isActive in onRestore to work-around crbug.com/394819.

Check isActive in onRestore to work-around crbug.com/394819.

Also fixes a related bug involving exiting full-screen. If the window was previously maximized when it is full-screened, then ChromeOS sometimes generates an onMaximized event when exiting full-screen, which triggers the app to re-enter full-screen mode. The fix is to explicitly unmaximize the window before going full-screen (which also has the nice benefit of making the double restore() calls unnecessary).

BUG=384678
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283972

[Wez, 2014-07-17 18:49:42]

lgtm

https://codereview.chromium.org/398403002/diff/1/remoting/webapp/fullscreen_v...
File remoting/webapp/fullscreen_v2.js (right):

https://codereview.chromium.org/398403002/diff/1/remoting/webapp/fullscreen_v...
remoting/webapp/fullscreen_v2.js:117: // so test the full-screen status to make
sure that this callback is
nit: Clarify what you mean by this; i.e. what you mean is "don't do anything if
we receive onRestored_ but Chrome indicates that full-screen is actually
active." I think?

[kelvinp, 2014-07-17 19:59:25]

On 2014/07/17 18:49:42, Wez wrote:
> lgtm
> 
>
https://codereview.chromium.org/398403002/diff/1/remoting/webapp/fullscreen_v...
> File remoting/webapp/fullscreen_v2.js (right):
> 
>
https://codereview.chromium.org/398403002/diff/1/remoting/webapp/fullscreen_v...
> remoting/webapp/fullscreen_v2.js:117: // so test the full-screen status to
make
> sure that this callback is
> nit: Clarify what you mean by this; i.e. what you mean is "don't do anything
if
> we receive onRestored_ but Chrome indicates that full-screen is actually
> active." I think?

As discussed, there may be some corner cases around maximizing the window using
double click that may need to be handled.  Please update the CL once those
issues are ironed out.

[Jamie, 2014-07-17 21:36:44]

https://codereview.chromium.org/398403002/diff/1/remoting/webapp/fullscreen_v...
File remoting/webapp/fullscreen_v2.js (right):

https://codereview.chromium.org/398403002/diff/1/remoting/webapp/fullscreen_v...
remoting/webapp/fullscreen_v2.js:117: // so test the full-screen status to make
sure that this callback is
On 2014/07/17 18:49:42, Wez wrote:
> nit: Clarify what you mean by this; i.e. what you mean is "don't do anything
if
> we receive onRestored_ but Chrome indicates that full-screen is actually
> active." I think?

Done.

[Jamie, 2014-07-17 21:39:17]

ptal

[kelvinp, 2014-07-17 21:40:43]

lgtm

[Jamie, 2014-07-17 21:43:39]

The CQ bit was checked by jamiewalch@chromium.org

[commit-bot: I haz the power, 2014-07-17 21:46:12]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jamiewalch@chromium.org/398403002/40001

[commit-bot: I haz the power, 2014-07-18 02:16:30]

Change committed as 283972