Require a mouse button release event before counting a press event as a new click.

ui/events/event.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/events/event.h"
 
 #if defined(USE_X11)
 #include <X11/extensions/XInput2.h>
 #include <X11/Xlib.h>
 #endif
@@ skipping 299 matching lines @@
   if (std::abs(event2.y() - event1.y()) > kDoubleClickHeight / 2)
     return false;
 
   return true;
 }
 
 // static
 int MouseEvent::GetRepeatCount(const MouseEvent& event) {
   int click_count = 1;
   if (last_click_event_) {
-    if (event.type() == ui::ET_MOUSE_RELEASED)
+    if (event.type() == ui::ET_MOUSE_RELEASED) {
+      last_click_released_ = true;

[sky, 2014/07/17 21:37:55]

If you get a capture change I'm not sure if you are guaranteed a release. I also
think you need to check the changed flags. For example, if you first click the
right button then click/release/click the left button that likely shouldn't be a
double click.

[flackr, 2014/07/18 16:20:49]

If the event is handled within chrome this is called from the MouseEvent
constructor, we should see it I think. Or am I missing something? Is there a
circumstance I should be testing for this?
The left click/release/click is a double click isn't it? I have added a check to
only set last_click_released_ if the changed button flag matches and added a
test with the event sequence you described, please let me know if I
misunderstood, thanks!

[sky, 2014/07/18 19:20:59]

What I'm saying is that I'm not sure if we necessarily get a release on a
capture change. If that happens won't these variables be wrong?
I believe that is what I'm after.

[flackr, 2014/07/18 19:45:23]

Ah I see what you're saying. If I double click, and lose the release for the
second click, the next click on the application would assume it was still part
of that double click.

For the case I'm trying to handle the native timestamps of event and
last_click_event_ should be the same, how about if we set last_click_released_ =
true on a later timestamp as well?

Alternately, since these clicks will be far apart I could call
IsRepeatedClickEvent and reset click_count if false.

       return last_click_event_->GetClickCount();
-    if (IsX11SendEventTrue(event.native_event()))
+    }
+    if (!last_click_released_ ||
+        IsX11SendEventTrue(event.native_event())) {
       click_count = last_click_event_->GetClickCount();
-    else if (IsRepeatedClickEvent(*last_click_event_, event))
+    } else if (IsRepeatedClickEvent(*last_click_event_, event)) {
       click_count = last_click_event_->GetClickCount() + 1;
+    }
     delete last_click_event_;
   }
   last_click_event_ = new MouseEvent(event);
+  last_click_released_ = false;
   if (click_count > 3)
     click_count = 3;
   last_click_event_->SetClickCount(click_count);
   return click_count;
 }
 
 // static
 MouseEvent* MouseEvent::last_click_event_ = NULL;
+bool MouseEvent::last_click_released_ = false;
 
 int MouseEvent::GetClickCount() const {
   if (type() != ET_MOUSE_PRESSED && type() != ET_MOUSE_RELEASED)
     return 0;
 
   if (flags() & EF_IS_TRIPLE_CLICK)
     return 3;
   else if (flags() & EF_IS_DOUBLE_CLICK)
     return 2;
   else
@@ skipping 402 matching lines @@
                    gfx::PointF(x, y),
                    time_stamp,
                    flags | EF_FROM_TOUCH),
       details_(details) {
 }
 
 GestureEvent::~GestureEvent() {
 }
 
 }  // namespace ui