Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 398373006: Audit the last time the media stream content settings have been used. (Closed)

Created:
6 years, 5 months ago by Daniel Nishi
Modified:
6 years, 5 months ago
CC:
scheib, chromium-reviews, posciak+watch_chromium.org, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, markusheintz_, wjia+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Audit the last time the media stream content settings have been used. This will be used as part of a resource/permission manager which will allow users to easily see and modify which permissions are being granted to which websites. Design Doc: https://docs.google.com/document/d/1oQwmj3AU4QYhTyGrYEGr6zaZhHUfx-wqUgEcQGbUU-U/edit?usp=sharing BUG=372607 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284202

Patch Set 1 #

Total comments: 2

Patch Set 2 : Indent fixing. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -6 lines) Patch
M chrome/browser/content_settings/host_content_settings_map.h View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/media/media_stream_devices_controller.cc View 1 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Daniel Nishi
bauerb@chromium.org: Please review changes in chrome/browser/content_settings/host_content_settings_map.h tommi@chromium.org: Please review changes in chrome/browser/media/media_stream_devices_controller.cc
6 years, 5 months ago (2014-07-17 22:45:46 UTC) #1
Daniel Nishi
+scheib (CC) FYI
6 years, 5 months ago (2014-07-17 22:47:57 UTC) #2
tommi (sloooow) - chröme
lgtm w/indent fix https://codereview.chromium.org/398373006/diff/1/chrome/browser/media/media_stream_devices_controller.cc File chrome/browser/media/media_stream_devices_controller.cc (right): https://codereview.chromium.org/398373006/diff/1/chrome/browser/media/media_stream_devices_controller.cc#newcode351 chrome/browser/media/media_stream_devices_controller.cc:351: ContentSettingsPattern::FromURLNoWildcard(request_.security_origin), 4 space indent here and ...
6 years, 5 months ago (2014-07-18 07:30:25 UTC) #3
Bernhard Bauer
lgtm
6 years, 5 months ago (2014-07-18 07:49:36 UTC) #4
Daniel Nishi
https://codereview.chromium.org/398373006/diff/1/chrome/browser/media/media_stream_devices_controller.cc File chrome/browser/media/media_stream_devices_controller.cc (right): https://codereview.chromium.org/398373006/diff/1/chrome/browser/media/media_stream_devices_controller.cc#newcode351 chrome/browser/media/media_stream_devices_controller.cc:351: ContentSettingsPattern::FromURLNoWildcard(request_.security_origin), On 2014/07/18 07:30:24, tommi wrote: > 4 space ...
6 years, 5 months ago (2014-07-18 15:59:26 UTC) #5
Daniel Nishi
The CQ bit was checked by dhnishi@chromium.org
6 years, 5 months ago (2014-07-18 15:59:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dhnishi@chromium.org/398373006/20001
6 years, 5 months ago (2014-07-18 16:00:26 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-18 19:42:39 UTC) #8
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 21:26:35 UTC) #9
Message was sent while issue was closed. 
Change committed as 284202

Powered by Google App Engine
This is Rietveld 408576698