Cleanup safe mode tests.

Cleanup safe mode tests.

- Adds a positive test, where the owner logs-in while in safe mode.
- Fixes the test, where a non-owner tries to login: It failed because the MockOwnerKeyUtil had no key set. Now it fails because the private key cannot be found.
- Removes the ScopedTestNSSDB usage.
- Speeds up the test by factor 10, because of the removed NSS initialization in the test fixture.

BUG=210525
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284106

[pneubeck (no reviews), 2014-07-17 15:28:47]

Hey Toni,
I think you're the right one to review this.
AFAIU, there was not positive test for safe mode, i.e. where we go through
safe-mode and the owner tries to login.

I added that and removed the ScopedTestNSSDB.
Please take a look.

[pneubeck (no reviews), 2014-07-17 15:35:36]

updated the commit message to give some explanation.

[pneubeck (no reviews), 2014-07-18 08:55:22]

@Yuri, could you take a look whether the usage of the login idioms in the test
is correct / makes sense?

[ygorshenin1, 2014-07-18 10:27:46]

lgtm

https://codereview.chromium.org/398363002/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/login/auth/parallel_authenticator_unittest.cc
(right):

https://codereview.chromium.org/398363002/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/login/auth/parallel_authenticator_unittest.cc:430:
device_settings_provider =
nit: move device_settings_provider declaration here.

https://codereview.chromium.org/398363002/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/login/auth/parallel_authenticator_unittest.cc:435:
CrosSettings::Get()->AddSettingsProvider(&stub_settings_provider);
nit: move stub_settings_provider declaration here.

[pneubeck (no reviews), 2014-07-18 12:20:30]

Discussed the change also with pastarmovj@, who originally added safe mode.

https://codereview.chromium.org/398363002/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/login/auth/parallel_authenticator_unittest.cc
(right):

https://codereview.chromium.org/398363002/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/login/auth/parallel_authenticator_unittest.cc:430:
device_settings_provider =
On 2014/07/18 10:27:46, ygorshenin1 wrote:
> nit: move device_settings_provider declaration here.

Done.

https://codereview.chromium.org/398363002/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/login/auth/parallel_authenticator_unittest.cc:435:
CrosSettings::Get()->AddSettingsProvider(&stub_settings_provider);
On 2014/07/18 10:27:46, ygorshenin1 wrote:
> nit: move stub_settings_provider declaration here.

Done.

[pneubeck (no reviews), 2014-07-18 12:20:35]

The CQ bit was checked by pneubeck@chromium.org

[commit-bot: I haz the power, 2014-07-18 12:21:21]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pneubeck@chromium.org/398363002/60001

[commit-bot: I haz the power, 2014-07-18 16:03:46]

Change committed as 284106