Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Side by Side Diff: Source/core/rendering/RenderBlock.cpp

Issue 398343003: Use unified invalidation path for repaint-only style changes (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Update naming Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2007 David Smith (catfish.man@gmail.com) 4 * (C) 2007 David Smith (catfish.man@gmail.com)
5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved. 5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
6 * Copyright (C) Research In Motion Limited 2010. All rights reserved. 6 * Copyright (C) Research In Motion Limited 2010. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 346 matching lines...) Expand 10 before | Expand all | Expand 10 after
357 Vector<ImageResource*> images; 357 Vector<ImageResource*> images;
358 appendImagesFromStyle(images, *newStyle); 358 appendImagesFromStyle(images, *newStyle);
359 if (images.isEmpty()) 359 if (images.isEmpty())
360 ResourceLoadPriorityOptimizer::resourceLoadPriorityOptimizer()->removeRe nderObject(this); 360 ResourceLoadPriorityOptimizer::resourceLoadPriorityOptimizer()->removeRe nderObject(this);
361 else 361 else
362 ResourceLoadPriorityOptimizer::resourceLoadPriorityOptimizer()->addRende rObject(this); 362 ResourceLoadPriorityOptimizer::resourceLoadPriorityOptimizer()->addRende rObject(this);
363 } 363 }
364 364
365 void RenderBlock::invalidateTreeIfNeeded(const PaintInvalidationState& paintInva lidationState) 365 void RenderBlock::invalidateTreeIfNeeded(const PaintInvalidationState& paintInva lidationState)
366 { 366 {
367 // Note, we don't want to early out here using shouldCheckForInvalidationAft erLayout as 367 if (!shouldCheckForSelfOrChildPaintInvalidation())
368 // we have to make sure we go through any positioned objects as they won't b e seen in 368 return;
369 // the normal tree walk.
370 369
371 if (shouldCheckForPaintInvalidation()) 370 RenderBox::invalidateTreeIfNeeded(paintInvalidationState);
372 RenderBox::invalidateTreeIfNeeded(paintInvalidationState);
373 371
374 // Take care of positioned objects. This is required as PaintInvalidationSta te keeps a single clip rect. 372 // Take care of positioned objects. This is required as PaintInvalidationSta te keeps a single clip rect.
375 if (TrackedRendererListHashSet* positionedObjects = this->positionedObjects( )) { 373 if (TrackedRendererListHashSet* positionedObjects = this->positionedObjects( )) {
376 TrackedRendererListHashSet::iterator end = positionedObjects->end(); 374 TrackedRendererListHashSet::iterator end = positionedObjects->end();
377 bool establishesNewPaintInvalidationContainer = isPaintInvalidationConta iner(); 375 bool establishesNewPaintInvalidationContainer = isPaintInvalidationConta iner();
378 const RenderLayerModelObject& newPaintInvalidationContainer = *adjustCom positedContainerForSpecialAncestors(establishesNewPaintInvalidationContainer ? t his : &paintInvalidationState.paintInvalidationContainer()); 376 const RenderLayerModelObject& newPaintInvalidationContainer = *adjustCom positedContainerForSpecialAncestors(establishesNewPaintInvalidationContainer ? t his : &paintInvalidationState.paintInvalidationContainer());
379 PaintInvalidationState childPaintInvalidationState(paintInvalidationStat e, *this, newPaintInvalidationContainer); 377 PaintInvalidationState childPaintInvalidationState(paintInvalidationStat e, *this, newPaintInvalidationContainer);
380 for (TrackedRendererListHashSet::iterator it = positionedObjects->begin( ); it != end; ++it) { 378 for (TrackedRendererListHashSet::iterator it = positionedObjects->begin( ); it != end; ++it) {
381 RenderBox* box = *it; 379 RenderBox* box = *it;
382 380
(...skipping 4556 matching lines...) Expand 10 before | Expand all | Expand 10 after
4939 void RenderBlock::showLineTreeAndMark(const InlineBox* markedBox1, const char* m arkedLabel1, const InlineBox* markedBox2, const char* markedLabel2, const Render Object* obj) const 4937 void RenderBlock::showLineTreeAndMark(const InlineBox* markedBox1, const char* m arkedLabel1, const InlineBox* markedBox2, const char* markedLabel2, const Render Object* obj) const
4940 { 4938 {
4941 showRenderObject(); 4939 showRenderObject();
4942 for (const RootInlineBox* root = firstRootBox(); root; root = root->nextRoot Box()) 4940 for (const RootInlineBox* root = firstRootBox(); root; root = root->nextRoot Box())
4943 root->showLineTreeAndMark(markedBox1, markedLabel1, markedBox2, markedLa bel2, obj, 1); 4941 root->showLineTreeAndMark(markedBox1, markedLabel1, markedBox2, markedLa bel2, obj, 1);
4944 } 4942 }
4945 4943
4946 #endif 4944 #endif
4947 4945
4948 } // namespace WebCore 4946 } // namespace WebCore
OLDNEW
« no previous file with comments | « no previous file | Source/core/rendering/RenderBox.h » ('j') | Source/core/rendering/RenderObject.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698