Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Issue 39833003: Android: kill all adb instances before trying to restart usb. (Closed)

Created:
7 years, 2 months ago by bulach
Modified:
7 years, 1 month ago
Reviewers:
navabi1, tonyg, navabi
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org, rmcilroy
Visibility:
Public.

Description

Android: kill all adb instances before trying to restart usb. On some bots, there are adb instances left over from previous runs. They don't play well with restarting the usb, and devices eventually "disappear". This tries to kill all adb instances before restarting usb. BUG=311058 TBR=navabi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=231035

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M build/android/buildbot/bb_device_status_check.py View 3 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
bulach
ptal
7 years, 2 months ago (2013-10-24 10:58:29 UTC) #1
tonyg
lgtm
7 years, 2 months ago (2013-10-24 14:23:53 UTC) #2
navabi
lgtm
7 years, 2 months ago (2013-10-24 18:48:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/39833003/1
7 years, 2 months ago (2013-10-25 09:19:00 UTC) #4
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=32544
7 years, 2 months ago (2013-10-25 09:36:22 UTC) #5
bulach
presubmit fail because the lgtm came from @google :) trying to CQ with a TBR ...
7 years, 2 months ago (2013-10-25 10:09:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/39833003/1
7 years, 2 months ago (2013-10-25 10:10:51 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=213633
7 years, 1 month ago (2013-10-25 12:07:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/39833003/1
7 years, 1 month ago (2013-10-25 12:23:10 UTC) #9
commit-bot: I haz the power
Change committed as 231035
7 years, 1 month ago (2013-10-25 16:32:45 UTC) #10
Isaac (away)
This code it sends all three signals without delay, so everything will get a kill ...
7 years, 1 month ago (2013-11-01 19:12:31 UTC) #11
bulach
7 years, 1 month ago (2013-11-04 17:39:14 UTC) #12
Message was sent while issue was closed.
I'll take on the improvements, thanks!

Powered by Google App Engine
This is Rietveld 408576698