Issue 398293003: WebAudio: Remove AudioSchedulesSourceNode::NotifyEndedTask

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 398293003: WebAudio: Remove AudioSchedulesSourceNode::NotifyEndedTask (Closed)

Created:
6 years, 5 months ago by tkent

Modified:
6 years, 5 months ago

Reviewers:
oilpan-reviews, haraken, Mads Ager (chromium), Raymond Toy

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

WebAudio: Remove AudioScheduledSourceNode::NotifyEndedTask We can simplify the code by createCrossThreadTask. BUG=392788 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178409

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -33 lines)			Patch
	M	Source/modules/webaudio/AudioScheduledSourceNode.h	View		2 chunks	+1 line, -12 lines	0 comments	Download
	M	Source/modules/webaudio/AudioScheduledSourceNode.cpp	View	1	2 chunks	+13 lines, -21 lines	0 comments	Download

Total messages: 7 (0 generated)

Mads Ager (chromium)

LGTM, but Raymond should have a look as well.

6 years, 5 months ago (2014-07-17 09:59:25 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/398293003/20001

6 years, 5 months ago (2014-07-17 23:46:35 UTC) #6

Message was sent while issue was closed.

Change committed as 178409