Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 398273006: Revert 284234 "Pass signin_scoped_device_id to DeviceInfoSpecifics." (Closed)

Created:
6 years, 5 months ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years, 5 months ago
Reviewers:
pavely
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 284234 "Pass signin_scoped_device_id to DeviceInfoSpecifics." Compilation error on Win builder. src\sync\internal_api\public\base\invalidation_util.cc(14) : fatal error C1083: Cannot open include file: 'google/cacheinvalidation/types.pb.h': No such file or directory > Pass signin_scoped_device_id to DeviceInfoSpecifics. > > I'm adding signin_scoped_device_id to DeviceInfoSpecifics. > This value is available from SigninClient, the rest of code is to pass > value from syncBackendHostImpl where SigninClient is availble to > SyncedDeviceTracker where value is passed to protobuf. > > Also there is small change to how commandline flag is handled. > > BUG=382968 > R=rlarocque@chromium.org > > Review URL: https://codereview.chromium.org/395013002 TBR=pavely@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284242

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -201 lines) Patch
M trunk/src/chrome/browser/extensions/api/sessions/sessions_apitest.cc View 1 chunk +1 line, -2 lines 0 comments Download
MM trunk/src/chrome/browser/extensions/api/signed_in_devices/id_mapping_helper_unittest.cc View 2 chunks +9 lines, -19 lines 0 comments Download
M trunk/src/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api_unittest.cc View 4 chunks +21 lines, -32 lines 0 comments Download
M trunk/src/chrome/browser/sync/glue/device_info.h View 5 chunks +1 line, -10 lines 0 comments Download
M trunk/src/chrome/browser/sync/glue/device_info.cc View 6 chunks +18 lines, -27 lines 0 comments Download
M trunk/src/chrome/browser/sync/glue/sync_backend_host_core.h View 3 chunks +5 lines, -9 lines 0 comments Download
M trunk/src/chrome/browser/sync/glue/sync_backend_host_core.cc View 4 chunks +3 lines, -7 lines 0 comments Download
M trunk/src/chrome/browser/sync/glue/sync_backend_host_impl.cc View 4 chunks +1 line, -10 lines 0 comments Download
M trunk/src/chrome/browser/sync/glue/synced_device_tracker.h View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/chrome/browser/sync/glue/synced_device_tracker.cc View 5 chunks +12 lines, -19 lines 0 comments Download
M trunk/src/chrome/browser/sync/glue/synced_device_tracker_unittest.cc View 6 chunks +32 lines, -48 lines 0 comments Download
M trunk/src/chrome/browser/sync/profile_sync_service_factory.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/sync/sessions/sessions_sync_manager_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller_unittest.mm View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model_unittest.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M trunk/src/sync/protocol/device_info_specifics.proto View 1 chunk +0 lines, -4 lines 0 comments Download
M trunk/src/sync/protocol/proto_value_conversions.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Vitaly Buka (NO REVIEWS)
6 years, 5 months ago (2014-07-18 23:06:08 UTC) #1
Vitaly Buka (NO REVIEWS)
6 years, 5 months ago (2014-07-18 23:06:22 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r284242 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698