Issue 398273002: [NaCl] Build fix for disable_nacl=1

Issue 398273002: [NaCl] Build fix for disable_nacl=1 (Closed)

Created:
6 years, 5 months ago by tzik

Modified:
6 years, 5 months ago

Reviewers:
Lei Zhang

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

[NaCl] Build fix for disable_nacl=1 desktop chrome build. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283715

Patch Set 3 : drop kNaClPluginMimeType #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -0 lines)			Patch
M	chrome/browser/extensions/plugin_manager.h	View	1	2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/plugin_manager.cc	View	1 2	7 chunks	+10 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/startup/bad_flags_prompt.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/chrome_manifest_handlers.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/test/ppapi/ppapi_test.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

https://codereview.chromium.org/398273002/diff/1/chrome/browser/component_updater/pnacl/pnacl_component_installer.cc File chrome/browser/component_updater/pnacl/pnacl_component_installer.cc (right): https://codereview.chromium.org/398273002/diff/1/chrome/browser/component_updater/pnacl/pnacl_component_installer.cc#newcode379 chrome/browser/component_updater/pnacl/pnacl_component_installer.cc:379: updates_disabled_ = command_line.HasSwitch(switches::kDisablePnaclInstall); There's another CL to remove this. ...

6 years, 5 months ago (2014-07-17 05:33:47 UTC) #1

tzik

Updated! https://codereview.chromium.org/398273002/diff/1/chrome/browser/component_updater/pnacl/pnacl_component_installer.cc File chrome/browser/component_updater/pnacl/pnacl_component_installer.cc (right): https://codereview.chromium.org/398273002/diff/1/chrome/browser/component_updater/pnacl/pnacl_component_installer.cc#newcode379 chrome/browser/component_updater/pnacl/pnacl_component_installer.cc:379: updates_disabled_ = command_line.HasSwitch(switches::kDisablePnaclInstall); On 2014/07/17 05:33:47, Lei Zhang ...

6 years, 5 months ago (2014-07-17 05:53:31 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/398273002/40001

6 years, 5 months ago (2014-07-17 06:10:54 UTC) #5

Message was sent while issue was closed.

Change committed as 283715

Expand Messages | Collapse Messages