Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1748)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 398263003: DevTools: DataGrid: properly refresh detached nodes. (Closed)

Created:
6 years, 5 months ago by eustas
Modified:
6 years, 5 months ago
Reviewers:
vsevik, lushnikov
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

DevTools: DataGrid: properly refresh detached nodes. I've found that requests in network panel are not refreshed, because detached nodes ignore refresh request. BUG=316092 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178369

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M Source/devtools/front_end/ui/DataGrid.js View 1 2 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
eustas
6 years, 5 months ago (2014-07-17 06:09:26 UTC) #1
lushnikov
https://codereview.chromium.org/398263003/diff/1/Source/devtools/front_end/ui/DataGrid.js File Source/devtools/front_end/ui/DataGrid.js (right): https://codereview.chromium.org/398263003/diff/1/Source/devtools/front_end/ui/DataGrid.js#newcode1285 Source/devtools/front_end/ui/DataGrid.js:1285: createCells: function() lets add @protected
6 years, 5 months ago (2014-07-17 09:18:31 UTC) #2
eustas
https://codereview.chromium.org/398263003/diff/1/Source/devtools/front_end/ui/DataGrid.js File Source/devtools/front_end/ui/DataGrid.js (right): https://codereview.chromium.org/398263003/diff/1/Source/devtools/front_end/ui/DataGrid.js#newcode1285 Source/devtools/front_end/ui/DataGrid.js:1285: createCells: function() On 2014/07/17 09:18:30, lushnikov wrote: > lets ...
6 years, 5 months ago (2014-07-17 10:16:51 UTC) #3
lushnikov
lgtm
6 years, 5 months ago (2014-07-17 12:24:40 UTC) #4
vsevik
lgtm
6 years, 5 months ago (2014-07-17 12:29:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eustas@chromium.org/398263003/20001
6 years, 5 months ago (2014-07-17 12:29:56 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 13:29:53 UTC) #7
Message was sent while issue was closed. 
Change committed as 178369

Powered by Google App Engine
This is Rietveld 408576698