Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 398243002: Fix the path to blink_resources. (Closed)

Created:
6 years, 5 months ago by tfarina
Modified:
6 years, 5 months ago
Reviewers:
jamesr
CC:
chromium-reviews, ozone-reviews_chromium.org, darin (slow to review), jam, android-webview-reviews_chromium.org, piman+watch_chromium.org, abarth-chromium, jochen (gone - plz use gerrit)
Project:
chromium
Visibility:
Public.

Description

Fix the path to blink_resources. We added a new blink_resources.gyp file to Blink repo in order to get rid of blink_chromium_resources action from webkit_resources.gyp and make the migration easier in https://src.chromium.org/viewvc/blink?revision=178275&view=revision This updates the Chromium side to reference the new generated path. BUG=338338 TEST=None R=jamesr@chromium.org TBR=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285524

Patch Set 1 #

Patch Set 2 : REBASE #

Patch Set 3 : fix #

Patch Set 4 : REBASE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -19 lines) Patch
M android_webview/android_webview.gyp View 1 2 chunks +2 lines, -1 line 0 comments Download
M athena/resources/athena_resources.gyp View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_repack_resources.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_resources.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M chromecast/chromecast.gyp View 1 2 chunks +2 lines, -1 line 0 comments Download
M components/components_tests.gyp View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/gpu/test_support_gpu.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content_child.gypi View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M content/content_shell.gypi View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M content/content_tests.gypi View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/webkit_resources.gyp View 1 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
tfarina
6 years, 5 months ago (2014-07-17 01:14:07 UTC) #1
jamesr
lgtm (although I obviously don't have owners for most of this)
6 years, 5 months ago (2014-07-17 20:31:40 UTC) #2
tfarina
TBRing Darin for the rest.
6 years, 5 months ago (2014-07-23 23:45:03 UTC) #3
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 5 months ago (2014-07-23 23:45:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/398243002/40001
6 years, 5 months ago (2014-07-23 23:47:10 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu on tryserver.chromium.gpu ...
6 years, 5 months ago (2014-07-24 06:05:36 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-24 06:20:29 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/37526)
6 years, 5 months ago (2014-07-24 06:20:30 UTC) #8
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 5 months ago (2014-07-24 12:26:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/398243002/40001
6 years, 5 months ago (2014-07-24 12:29:46 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu on tryserver.chromium.gpu ...
6 years, 5 months ago (2014-07-24 12:43:10 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-24 12:55:32 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/37673)
6 years, 5 months ago (2014-07-24 12:55:33 UTC) #13
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 5 months ago (2014-07-24 22:20:26 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/398243002/60001
6 years, 5 months ago (2014-07-24 22:25:06 UTC) #15
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-25 04:17:47 UTC) #16
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 07:50:04 UTC) #17
Message was sent while issue was closed.
Change committed as 285524

Powered by Google App Engine
This is Rietveld 408576698