Issue 398213002: Remove disable-pnacl-install flag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 398213002: Remove disable-pnacl-install flag. (Closed)

Created:
6 years, 5 months ago by jvoung (off chromium)

Modified:
6 years, 5 months ago

Reviewers:
waffles, Sorin Jianu, cpu_(ooo_6.6-7.5), Lei Zhang

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Remove disable-pnacl-install flag. This was added a while back to be able to quickly turn off component downloads for PNaCl if it got out of hand (via flipping the flag). It doesn't seem so necessary anymore, so remove it as part of the chrome flags cleanup effort. BUG=357762 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283698

Patch Set 1 #

Patch Set 2 : remove arg too #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -29 lines)			Patch
M	chrome/browser/chrome_browser_main.cc	View	1	3 chunks	+3 lines, -4 lines	0 comments	Download
M	chrome/browser/component_updater/pnacl/pnacl_component_installer.h	View		3 chunks	+1 line, -7 lines	0 comments	Download
M	chrome/browser/component_updater/pnacl/pnacl_component_installer.cc	View	1	4 chunks	+2 lines, -14 lines	0 comments	Download
M	components/nacl/common/nacl_switches.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	components/nacl/common/nacl_switches.cc	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

jvoung (off chromium)

(Lei for chrome/browser/chrome_browser_main.cc OWNERS)

6 years, 5 months ago (2014-07-17 00:04:32 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jvoung@chromium.org/398213002/20001

6 years, 5 months ago (2014-07-17 05:28:46 UTC) #6

Message was sent while issue was closed.

Change committed as 283698

Expand Messages | Collapse Messages