Issue 398203004: Build fix on Linux 64 bits with GCC 4.8.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 398203004: Build fix on Linux 64 bits with GCC 4.8. (Closed)

Created:
6 years, 5 months ago by darktears

Modified:
6 years, 5 months ago

Reviewers:
Shu Chen, sadrul, garykac

CC:
chromium-reviews, tdresser+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Build fix on Linux 64 bits with GCC 4.8. error: narrowing conversion of ‘(keysym & 65535ul)’ from ‘KeySym {aka long unsigned int}’ to ‘uint16 {aka short unsigned int}’ inside { } is ill-formed in C++11 error: narrowing conversion of ‘xkey.XKeyEvent::keycode’ from ‘unsigned int’ to ‘uint8 {aka unsigned char}’ Fixed by using the underlaying type instead, KeySym and unsigned. BUG=394636 TEST=Passed try bots. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283930

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -10 lines)			Patch
	M	ui/events/keycodes/keyboard_code_conversion_x.cc	View		4 chunks	+10 lines, -10 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexis.menard@intel.com/398203004/1

6 years, 5 months ago (2014-07-17 22:58:45 UTC) #5

Message was sent while issue was closed.

Change committed as 283930

Expand Messages | Collapse Messages