Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 398173002: Enable x64 Chromoting host and installer (Closed)

Created:
6 years, 5 months ago by dcaiafa
Modified:
6 years, 5 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, chromoting-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Enable x64 Chromoting host and installer N.B. I had to move the sawbuck_provider in the .wxs out of the installation directory. Even though it only contains registry changes, candle will complain if it is not inside a directory, but the application directory is platform specific, whereas sawbuck_provider is always 32-bit. BUG=394467 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284007

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : Always define sas_dll_path #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -18 lines) Patch
M build/common.gypi View 1 2 2 chunks +8 lines, -1 line 0 comments Download
M remoting/host/installer/win/chromoting.wxs View 4 chunks +25 lines, -17 lines 0 comments Download
M remoting/remoting_host_win.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/tools/zip2msi.py View 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
dcaiafa
6 years, 5 months ago (2014-07-16 19:45:31 UTC) #1
Sergey Ulanov
lgtm https://codereview.chromium.org/398173002/diff/1/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/398173002/diff/1/build/common.gypi#newcode954 build/common.gypi:954: 'conditions': [ Instead of putting condition inside of ...
6 years, 5 months ago (2014-07-16 19:54:12 UTC) #2
dcaiafa
The CQ bit was checked by dcaiafa@chromium.org
6 years, 5 months ago (2014-07-16 22:21:46 UTC) #3
dcaiafa
Thanks! https://codereview.chromium.org/398173002/diff/1/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/398173002/diff/1/build/common.gypi#newcode954 build/common.gypi:954: 'conditions': [ On 2014/07/16 19:54:12, Sergey Ulanov wrote: ...
6 years, 5 months ago (2014-07-16 22:22:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcaiafa@chromium.org/398173002/20001
6 years, 5 months ago (2014-07-16 22:24:38 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 5 months ago (2014-07-17 02:25:59 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-17 02:29:20 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/207227) ios_rel_device on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds/160034) ios_rel_device_ninja ...
6 years, 5 months ago (2014-07-17 02:29:21 UTC) #8
dcaiafa
The CQ bit was checked by dcaiafa@chromium.org
6 years, 5 months ago (2014-07-17 17:48:10 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcaiafa@chromium.org/398173002/20001
6 years, 5 months ago (2014-07-17 17:50:18 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 5 months ago (2014-07-17 18:45:10 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-17 18:48:05 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/40661)
6 years, 5 months ago (2014-07-17 18:48:05 UTC) #13
dcaiafa
The CQ bit was checked by dcaiafa@chromium.org
6 years, 5 months ago (2014-07-18 00:24:10 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcaiafa@chromium.org/398173002/40001
6 years, 5 months ago (2014-07-18 00:28:20 UTC) #15
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 05:32:18 UTC) #16
Message was sent while issue was closed.
Change committed as 284007

Powered by Google App Engine
This is Rietveld 408576698