Export content_common dependency from some content targets.

Add content::NotificationPresenterPermission.

This removes Blink header dependency from content_browser_client.h.

BUG=350097

[tkent, 2014-07-17 02:27:03]

Please review this.
This CL will fix the Windows build failure in
https://codereview.chromium.org/189703002/#msg7

[jochen (gone - plz use gerrit), 2014-07-17 07:09:01]

On 2014/07/17 at 02:27:03, tkent wrote:
> Please review this.
> This CL will fix the Windows build failure in
https://codereview.chromium.org/189703002/#msg7

wouldn't it be better if browser/ didn't have stuff from public/web? we could
introduce a content type for the permissions (or it could just use one of the
content settings types)

[tkent, 2014-07-17 07:56:52]

On 2014/07/17 07:09:01, jochen wrote:
> wouldn't it be better if browser/ didn't have stuff from public/web? we could
> introduce a content type for the permissions (or it could just use one of the
> content settings types)

It sounds better.  I'll try it.

[tkent, 2014-07-17 08:35:07]

On 2014/07/17 07:56:52, tkent wrote:
> It sounds better.  I'll try it.

I uploaded new patch.  Please take another look.

[jochen (gone - plz use gerrit), 2014-07-17 09:16:02]

lgtm

if you feel extra generous, you could change the
DesktopNotificationHostMsg_CheckPermission IPC to send back a
content::NotificationPresenterPermission instead of an int

[tkent, 2014-07-17 09:18:42]

+benm and boliu for android_webview.

> if you feel extra generous, you could change the
> DesktopNotificationHostMsg_CheckPermission IPC to send back a
> content::NotificationPresenterPermission instead of an int

In this case, should I move notification_presenter_permission.h to
content/public/common/?

[Peter Beverloo, 2014-07-17 09:42:19]

I added public/platform/WebNotificationPermission.h to get rid of the dependency
on public/web/, and started using it in the following CL which is still pending
reviews:

  https://codereview.chromium.org/381633005/

[Peter Beverloo, 2014-07-17 09:46:12]

On 2014/07/17 09:42:19, Peter Beverloo wrote:
> I added public/platform/WebNotificationPermission.h to get rid of the
dependency
> on public/web/, and started using it in the following CL which is still
pending
> reviews:
> 
>   https://codereview.chromium.org/381633005/

To clarify, CBC and dependencies will be updated to the new enum as well, but I
don't want that patch to touch even more layers.

[tkent, 2014-07-17 09:59:55]

On 2014/07/17 09:46:12, Peter Beverloo wrote:
> On 2014/07/17 09:42:19, Peter Beverloo wrote:
> > I added public/platform/WebNotificationPermission.h to get rid of the
> dependency
> > on public/web/, and started using it in the following CL which is still
> pending
> > reviews:
> > 
> >   https://codereview.chromium.org/381633005/
> 
> To clarify, CBC and dependencies will be updated to the new enum as well, but
I
> don't want that patch to touch even more layers.

Your CLs will resolve the issue.  This CL is not urgent and I can wait for your
CLs.
Closing this.

[tkent, 2014-07-23 03:44:19]

On 2014/07/17 09:59:55, tkent wrote:
> Your CLs will resolve the issue.  This CL is not urgent and I can wait for
your
> CLs.
> Closing this.

I found this CL was necessary to change |#include "WebFoo.h"| to |#include
"public/platform/WebFoo.h"| in public/platform/WebBar.h.  Perter's change won't
resolve this issue.

Reopening this, and landing it.

[tkent, 2014-07-23 03:44:46]

The CQ bit was checked by tkent@chromium.org

[tkent, 2014-07-23 03:44:50]

The CQ bit was unchecked by tkent@chromium.org

[Peter Beverloo, 2014-07-23 03:46:12]

On 2014/07/23 03:44:19, tkent wrote:
> On 2014/07/17 09:59:55, tkent wrote:
> > Your CLs will resolve the issue.  This CL is not urgent and I can wait for
> your
> > CLs.
> > Closing this.
> 
> I found this CL was necessary to change |#include "WebFoo.h"| to |#include
> "public/platform/WebFoo.h"| in public/platform/WebBar.h.  Perter's change
won't
> resolve this issue.
> 
> Reopening this, and landing it.

I don't understand that reason. Can you clarify why this is a problem? What kind
of build failure do we get? That header does not include any other files.

[tkent, 2014-07-23 03:46:23]

> Reopening this, and landing it.

I meant Patch Set 1.
Reusing this CL would be confusing.  I'll make another CL.

[tkent, 2014-07-23 03:48:41]

On 2014/07/23 03:46:12, Peter Beverloo wrote:
> I don't understand that reason. Can you clarify why this is a problem? What
kind
> of build failure do we get? That header does not include any other files.

Here is an example: https://codereview.chromium.org/414653002/

[Peter Beverloo, 2014-07-23 03:59:50]

On 2014/07/23 03:48:41, tkent wrote:
> On 2014/07/23 03:46:12, Peter Beverloo wrote:
> > I don't understand that reason. Can you clarify why this is a problem? What
> kind
> > of build failure do we get? That header does not include any other files.
> 
> Here is an example: https://codereview.chromium.org/414653002/

Right, so the problem occurs when a Chrome target includes a header in
public/platform/ which in turn includes another header in public/platform, when
said target does not explicitly depend on the "blink_headers" target.

WebNotificationPermission.h does not include any of such files. It will be
included by WebNotificationPresenter.h (which will move to public/platform/),
but the only references to that class will be in content/renderer/, which does
define a dependency on the "blink_headers" target.

Is the goal to not depend on any Blink headers outside of content/? Which
compilation unit triggers these failures?

Thank you for taking some time to clarify this to me.. :-).

[tkent, 2014-07-23 04:24:48]

On 2014/07/23 03:59:50, Peter Beverloo wrote:
> Right, so the problem occurs when a Chrome target includes a header in
> public/platform/ which in turn includes another header in public/platform,
when
> said target does not explicitly depend on the "blink_headers" target.
> 
> WebNotificationPermission.h does not include any of such files. It will be
> included by WebNotificationPresenter.h (which will move to public/platform/),
> but the only references to that class will be in content/renderer/, which does
> define a dependency on the "blink_headers" target.
> 
> Is the goal to not depend on any Blink headers outside of content/? Which
> compilation unit triggers these failures?

My goals are
1. Replace |#include "../platform/WebFoo.h"| with |#include
"public/platform/WebFoo.h" in public/web/*.h <crbug.com/350097>
2. Replace |#include "WebFoo.h"| with |#include "public/platform/WebFoo.h" in
public/platform/*.h

- Your CL will help 1.
- It's ok that content/ depends on Blink public headers.