Issue 398163006: Disable warning 4267 in pdfium until it is fixed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 398163006: Disable warning 4267 in pdfium until it is fixed. (Closed)

Created:
6 years, 5 months ago by Nico

Modified:
6 years, 5 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Visibility:
Public.

More Reviews

Description

Disable warning 4267 in pdfium until it is fixed. BUG=376399 TBR=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/8f75c67

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	pdfium.gyp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Nico

(see http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/builds/31463/steps/compile%20%28with%20patch%29/logs/stdio for breakage)

6 years, 5 months ago (2014-07-17 00:31:37 UTC) #2

Nico

Committed patchset #1 manually as r8f75c67 (presubmit successful).

6 years, 5 months ago (2014-07-17 00:32:00 UTC) #3

Message was sent while issue was closed.

lgtm

Would be nice to add it in order.

Expand Messages | Collapse Messages