Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 398163004: Fold DecoderSelector::Abort() into the dtor. (Closed)

Created:
6 years, 5 months ago by xhwang
Modified:
6 years, 5 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Fold DecoderSelector::Abort() into the dtor. BUG=349211 TEST=Existing tests pass. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284028

Patch Set 1 #

Patch Set 2 : rebase only #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -57 lines) Patch
M media/filters/audio_decoder_selector_unittest.cc View 11 chunks +17 lines, -17 lines 0 comments Download
M media/filters/decoder_selector.h View 2 chunks +3 lines, -4 lines 0 comments Download
M media/filters/decoder_selector.cc View 1 2 chunks +7 lines, -16 lines 0 comments Download
M media/filters/decoder_stream.cc View 1 1 chunk +1 line, -3 lines 0 comments Download
M media/filters/video_decoder_selector_unittest.cc View 11 chunks +17 lines, -17 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
xhwang
Here's another one :) We are getting closer.... PTAL
6 years, 5 months ago (2014-07-17 05:05:01 UTC) #1
scherkus (not reviewing)
lgtm
6 years, 5 months ago (2014-07-17 17:54:10 UTC) #2
xhwang
The CQ bit was checked by xhwang@chromium.org
6 years, 5 months ago (2014-07-17 23:06:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/398163004/1
6 years, 5 months ago (2014-07-17 23:07:49 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 5 months ago (2014-07-18 01:39:50 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-18 01:44:29 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/93858) android_chromium_gn_compile_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_compile_rel/builds/23640) android_dbg ...
6 years, 5 months ago (2014-07-18 01:44:29 UTC) #7
xhwang
rebase only
6 years, 5 months ago (2014-07-18 04:16:43 UTC) #8
xhwang
The CQ bit was checked by xhwang@chromium.org
6 years, 5 months ago (2014-07-18 04:17:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/398163004/20001
6 years, 5 months ago (2014-07-18 04:19:16 UTC) #10
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 07:25:34 UTC) #11
Message was sent while issue was closed.
Change committed as 284028

Powered by Google App Engine
This is Rietveld 408576698