Issue 398153002: Fix broken android framework builds where 32-bit MIPS compilers lack 64-bit __sync operators.

Issue 398153002: Fix broken android framework builds where 32-bit MIPS compilers lack 64-bit __sync operators. (Closed)

Created:
6 years, 5 months ago by djsollen

Modified:
6 years, 5 months ago

Reviewers:
scroggo, petarj, mtklein, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

Fix broken android framework builds where 32-bit MIPS compilers lack 64-bit __sync operators. R=mtklein@google.com, reed@google.com, scroggo@google.com Committed: https://skia.googlesource.com/skia/+/eccbfec

Patch Set 3 : rebase #

Total comments: 1

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -2 lines)			Patch
	M	gyp/common_conditions.gypi	View	1 2	1 chunk	+0 lines, -2 lines	0 comments	Download
	M	src/ports/SkAtomics_sync.h	View	1 2	1 chunk	+8 lines, -0 lines	1 comment	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

scroggo

https://codereview.chromium.org/398153002/diff/20001/include/core/SkPostConfig.h File include/core/SkPostConfig.h (right): https://codereview.chromium.org/398153002/diff/20001/include/core/SkPostConfig.h#newcode391 include/core/SkPostConfig.h:391: # elif defined(SK_BUILD_FOR_ANDROID_FRAMWORK) && defined(__mips__) && !defined(__LP64__) FRAMEWORK* (you ...

6 years, 5 months ago (2014-07-16 19:16:25 UTC) #4

scroggo

On 2014/07/16 19:36:03, djsollen wrote: > rebased and did some cleanup in the wake of ...

6 years, 5 months ago (2014-07-16 19:37:26 UTC) #6

petarj

https://codereview.chromium.org/398153002/diff/40001/src/ports/SkAtomics_sync.h File src/ports/SkAtomics_sync.h (right): https://codereview.chromium.org/398153002/diff/40001/src/ports/SkAtomics_sync.h#newcode20 src/ports/SkAtomics_sync.h:20: #if defined(SK_BUILD_FOR_ANDROID_FRAMEWORK) && defined(__mips__) && !defined(__LP64__) Can you remove ...

6 years, 5 months ago (2014-07-18 16:41:04 UTC) #9

djsollen

6 years, 5 months ago (2014-07-18 18:26:22 UTC) #10

Message was sent while issue was closed.

On 2014/07/18 16:41:04, petarj wrote:
>
https://codereview.chromium.org/398153002/diff/40001/src/ports/SkAtomics_sync.h
> File src/ports/SkAtomics_sync.h (right):
> 
>
https://codereview.chromium.org/398153002/diff/40001/src/ports/SkAtomics_sync...
> src/ports/SkAtomics_sync.h:20: #if defined(SK_BUILD_FOR_ANDROID_FRAMEWORK) &&
> defined(__mips__) && !defined(__LP64__)
> Can you remove this part: defined(SK_BUILD_FOR_ANDROID_FRAMEWORK) &&?
> The problem is common for MIPS Linux build as well and it has just
> broken MIPS Linux buildbot.
> 
> Thanks.

It has already been fixed in https://codereview.chromium.org/400753004/ and has
just landed into the chromium tree with a very recent Skia roll. The chromium
builds should be going green soon.

Expand Messages | Collapse Messages