In iossim, use the user's home directory if no override is given.

In iossim, use the user's home directory if no override is given.

If no override is given, simHomePath needs to be initialized or iossim
won't know where to find files (e.g. the simulator's sandboxed
system.log)

BUG=None

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283643

[smut, 2014-07-16 18:47:37]

lgtm % suggestion

https://chromiumcodereview.appspot.com/398133002/diff/20001/testing/iossim/io...
File testing/iossim/iossim.mm (right):

https://chromiumcodereview.appspot.com/398133002/diff/20001/testing/iossim/io...
testing/iossim/iossim.mm:912: if (!InitializeSimulatorUserHome(simHomePath)) {
Can you move this check below so it tries to initialize the fallback simHomePath
as well?

[lliabraa, 2014-07-16 18:49:53]

https://chromiumcodereview.appspot.com/398133002/diff/20001/testing/iossim/io...
File testing/iossim/iossim.mm (right):

https://chromiumcodereview.appspot.com/398133002/diff/20001/testing/iossim/io...
testing/iossim/iossim.mm:912: if (!InitializeSimulatorUserHome(simHomePath)) {
On 2014/07/16 18:47:37, smut wrote:
> Can you move this check below so it tries to initialize the fallback
simHomePath
> as well?

It's not necessary to initialize the directory when we're using the default

[lliabraa, 2014-07-16 18:49:55]

The CQ bit was checked by lliabraa@chromium.org

[smut, 2014-07-16 18:52:20]

https://chromiumcodereview.appspot.com/398133002/diff/20001/testing/iossim/io...
File testing/iossim/iossim.mm (right):

https://chromiumcodereview.appspot.com/398133002/diff/20001/testing/iossim/io...
testing/iossim/iossim.mm:912: if (!InitializeSimulatorUserHome(simHomePath)) {
On 2014/07/16 18:49:53, lliabraa wrote:
> On 2014/07/16 18:47:37, smut wrote:
> > Can you move this check below so it tries to initialize the fallback
> simHomePath
> > as well?
> 
> It's not necessary to initialize the directory when we're using the default

Ok. I wasn't sure what this did (e.g. maybe it checks write permissions, which
might be necessary).

[commit-bot: I haz the power, 2014-07-16 18:57:35]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/lliabraa@chromium.org/398133002/20001

[commit-bot: I haz the power, 2014-07-16 18:57:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-16 18:57:38]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[rohitrao (ping after 24h), 2014-07-16 19:13:10]

lgtm

[lliabraa, 2014-07-16 19:15:53]

The CQ bit was checked by lliabraa@chromium.org

[commit-bot: I haz the power, 2014-07-16 19:19:46]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/lliabraa@chromium.org/398133002/20001

[commit-bot: I haz the power, 2014-07-16 23:22:08]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-07-17 04:34:32]

Change committed as 283643