Issue 398093002: AVFoundation video capture: blacklisting micro fix

Issue 398093002: AVFoundation video capture: blacklisting micro fix (Closed)

Created:
6 years, 5 months ago by mcasas

Modified:
6 years, 5 months ago

Reviewers:
tommi (sloooow) - chröme

CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

AVFoundation video capture: blacklisting micro fix Where it reads = it should read |= so it keep the blacklisting mark. TBR=tommi@chromium.org BUG=347371 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283736

Patch Set 1 #

Total comments: 2

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	media/video/capture/mac/video_capture_device_factory_mac.mm	View		1 chunk	+1 line, -1 line	2 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mcasas@chromium.org/398093002/1

6 years, 5 months ago (2014-07-16 18:22:29 UTC) #2

tommi (sloooow) - chröme

https://codereview.chromium.org/398093002/diff/1/media/video/capture/mac/video_capture_device_factory_mac.mm File media/video/capture/mac/video_capture_device_factory_mac.mm (right): https://codereview.chromium.org/398093002/diff/1/media/video/capture/mac/video_capture_device_factory_mac.mm#newcode121 media/video/capture/mac/video_capture_device_factory_mac.mm:121: is_any_device_blacklisted |= EndsWith(name.id(), The loop breaks as soon as ...

6 years, 5 months ago (2014-07-17 10:46:57 UTC) #4

mcasas

6 years, 5 months ago (2014-07-17 11:25:13 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/398093002/diff/1/media/video/capture/mac/vide...
File media/video/capture/mac/video_capture_device_factory_mac.mm (right):

https://codereview.chromium.org/398093002/diff/1/media/video/capture/mac/vide...
media/video/capture/mac/video_capture_device_factory_mac.mm:121:
is_any_device_blacklisted |= EndsWith(name.id(),
On 2014/07/17 10:46:57, tommi wrote:
> The loop breaks as soon as is_any_device_blacklisted is set to true, so this
> doesn't make any difference.

This flag accumulates over the devices walked in the loop at line 107.

Expand Messages | Collapse Messages