chrome/browser/ui/webui/extensions/extension_settings_handler.cc - Issue 398083002: Add "UninstallReason" parameter to ExtensionRegistryObserver::OnExtensionUninstalled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/extensions/extension_settings_handler.cc

Issue 398083002: Add "UninstallReason" parameter to ExtensionRegistryObserver::OnExtensionUninstalled. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix header file. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/extensions/extension_settings_handler.h ('k') | chrome/browser/ui/webui/ntp/app_launcher_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/extensions/extension_settings_handler.cc

diff --git a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc

index 8960ce68eebb1a7f44776cc4f82994ab57f68935..9d99cbba7865e08dec54e8290b5637126d734a64 100644

--- a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc

+++ b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc

@@ -78,6 +78,7 @@

#include "extensions/browser/lazy_background_task_queue.h"

#include "extensions/browser/management_policy.h"

#include "extensions/browser/pref_names.h"

+#include "extensions/browser/uninstall_reason.h"

#include "extensions/browser/view_type_utils.h"

#include "extensions/common/constants.h"

#include "extensions/common/extension.h"

@@ -726,7 +727,8 @@ void ExtensionSettingsHandler::OnExtensionUnloaded(

void ExtensionSettingsHandler::OnExtensionUninstalled(

content::BrowserContext* browser_context,

- const Extension* extension) {

+ const Extension* extension,

+ extensions::UninstallReason reason) {

MaybeUpdateAfterNotification();

}

@@ -755,7 +757,7 @@ void ExtensionSettingsHandler::ExtensionUninstallAccepted() {

extension_service_->UninstallExtension(

extension_id_prompting_,

- ExtensionService::UNINSTALL_REASON_USER_INITIATED,

+ extensions::UNINSTALL_REASON_USER_INITIATED,

NULL); // Error.

extension_id_prompting_ = "";