chrome/browser/ui/browser_browsertest.cc - Issue 398083002: Add "UninstallReason" parameter to ExtensionRegistryObserver::OnExtensionUninstalled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_browsertest.cc

Issue 398083002: Add "UninstallReason" parameter to ExtensionRegistryObserver::OnExtensionUninstalled. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix header file. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/app_list/search/app_search_provider_unittest.cc ('k') | chrome/browser/ui/cocoa/apps/app_shim_menu_controller_mac_browsertest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/browser_browsertest.cc

diff --git a/chrome/browser/ui/browser_browsertest.cc b/chrome/browser/ui/browser_browsertest.cc

index 5686c58d30e58fefbd5aa1d10eb4618b2d5e540a..2dea9ffc4dc27a6da56a3d8aa4580d7f670ac2f3 100644

--- a/chrome/browser/ui/browser_browsertest.cc

+++ b/chrome/browser/ui/browser_browsertest.cc

@@ -80,6 +80,7 @@

#include "content/public/test/browser_test_utils.h"

#include "content/public/test/test_navigation_observer.h"

#include "extensions/browser/extension_system.h"

+#include "extensions/browser/uninstall_reason.h"

#include "extensions/common/extension.h"

#include "extensions/common/extension_set.h"

#include "grit/chromium_strings.h"

@@ -1307,9 +1308,8 @@ IN_PROC_BROWSER_TEST_F(BrowserTest, MAYBE_TabClosingWhenRemovingExtension) {

// Uninstall the extension and make sure TabClosing is sent.

ExtensionService* service = extensions::ExtensionSystem::Get(

browser()->profile())->extension_service();

- service->UninstallExtension(GetExtension()->id(),

- ExtensionService::UNINSTALL_REASON_FOR_TESTING,

- NULL);

+ service->UninstallExtension(

+ GetExtension()->id(), extensions::UNINSTALL_REASON_FOR_TESTING, NULL);

EXPECT_EQ(1, observer.closing_count());

model->RemoveObserver(&observer);