chrome/browser/notifications/desktop_notification_service.cc - Issue 398083002: Add "UninstallReason" parameter to ExtensionRegistryObserver::OnExtensionUninstalled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/desktop_notification_service.cc

Issue 398083002: Add "UninstallReason" parameter to ExtensionRegistryObserver::OnExtensionUninstalled. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/extension_service.cc ('K') | « chrome/browser/extensions/shared_module_service_unittest.cc ('k') | chrome/browser/performance_monitor/performance_monitor.cc » ('j') | chrome/browser/ui/app_list/extension_uninstaller.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/desktop_notification_service.cc

diff --git a/chrome/browser/notifications/desktop_notification_service.cc b/chrome/browser/notifications/desktop_notification_service.cc

index 2d605f819ea3475e513bbbbad2f9711825e2c61b..f591373202c878f5ac7ba79805df9c51cad6ae8a 100644

--- a/chrome/browser/notifications/desktop_notification_service.cc

+++ b/chrome/browser/notifications/desktop_notification_service.cc

@@ -696,14 +696,14 @@ void DesktopNotificationService::Observe(

#if defined(ENABLE_EXTENSIONS)

DCHECK_EQ(chrome::NOTIFICATION_EXTENSION_UNINSTALLED_DEPRECATED, type);

- extensions::Extension* extension =

- content::Details<extensions::Extension>(details).ptr();

- NotifierId notifier_id(NotifierId::APPLICATION, extension->id());

+ extensions::UninstalledExtensionInfo* info =

+ content::Details<extensions::UninstalledExtensionInfo>(details).ptr();

+ NotifierId notifier_id(NotifierId::APPLICATION, info->extension->id());

if (IsNotifierEnabled(notifier_id))

return;

// The settings for ephemeral apps will be persisted across cache evictions.

- if (extensions::util::IsEphemeralApp(extension->id(), profile_))

+ if (extensions::util::IsEphemeralApp(info->extension->id(), profile_))

return;

SetNotifierEnabled(notifier_id, true);