chrome/browser/extensions/extension_sync_service.cc - Issue 398083002: Add "UninstallReason" parameter to ExtensionRegistryObserver::OnExtensionUninstalled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_sync_service.cc

Issue 398083002: Add "UninstallReason" parameter to ExtensionRegistryObserver::OnExtensionUninstalled. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/extension_service.cc ('K') | « chrome/browser/extensions/extension_storage_monitor.cc ('k') | chrome/browser/extensions/external_install_error.cc » ('j') | chrome/browser/ui/app_list/extension_uninstaller.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_sync_service.cc

diff --git a/chrome/browser/extensions/extension_sync_service.cc b/chrome/browser/extensions/extension_sync_service.cc

index e1b1af255e5dff72fecab9ba397e0ab9e31bd38f..234877bd9efe5bfa92b20509661ea6faae0753fa 100644

--- a/chrome/browser/extensions/extension_sync_service.cc

+++ b/chrome/browser/extensions/extension_sync_service.cc

@@ -41,6 +41,7 @@ using extensions::Extension;

using extensions::ExtensionPrefs;

using extensions::ExtensionRegistry;

using extensions::FeatureSwitch;

+using extensions::UninstalledExtensionInfo;

namespace {

@@ -450,7 +451,7 @@ bool ExtensionSyncService::ProcessExtensionSyncDataHelper(

// Handle uninstalls first.

if (extension_sync_data.uninstalled()) {

if (!extension_service_->UninstallExtensionHelper(

- extension_service_, id, ExtensionService::UNINSTALL_REASON_SYNC)) {

+ extension_service_, id, UninstalledExtensionInfo::REASON_SYNC)) {

LOG(WARNING) << "Could not uninstall extension " << id

<< " for sync";

}