chrome/browser/extensions/extension_message_bubble_controller_unittest.cc - Issue 398083002: Add "UninstallReason" parameter to ExtensionRegistryObserver::OnExtensionUninstalled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_message_bubble_controller_unittest.cc

Issue 398083002: Add "UninstallReason" parameter to ExtensionRegistryObserver::OnExtensionUninstalled. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chrome_notification_types.h ('K') | « chrome/browser/extensions/extension_gcm_app_handler_unittest.cc ('k') | chrome/browser/extensions/extension_service.h » ('j') | chrome/browser/extensions/extension_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_message_bubble_controller_unittest.cc

diff --git a/chrome/browser/extensions/extension_message_bubble_controller_unittest.cc b/chrome/browser/extensions/extension_message_bubble_controller_unittest.cc

index 5f206a085b4783e9e2514cf4749a704e49e9c10c..2c8e38982e8fac5e40ddf9d82bd2731d383c42fa 100644

--- a/chrome/browser/extensions/extension_message_bubble_controller_unittest.cc

+++ b/chrome/browser/extensions/extension_message_bubble_controller_unittest.cc

@@ -721,11 +721,11 @@ TEST_F(ExtensionMessageBubbleTest, MAYBE_SettingsApiControllerTest) {

// Clean up after ourselves.

service_->UninstallExtension(

- kId1, ExtensionService::UNINSTALL_REASON_FOR_TESTING, NULL);

+ kId1, UninstalledExtensionInfo::REASON_FOR_TESTING, NULL);

service_->UninstallExtension(

- kId2, ExtensionService::UNINSTALL_REASON_FOR_TESTING, NULL);

+ kId2, UninstalledExtensionInfo::REASON_FOR_TESTING, NULL);

service_->UninstallExtension(

- kId3, ExtensionService::UNINSTALL_REASON_FOR_TESTING, NULL);

+ kId3, UninstalledExtensionInfo::REASON_FOR_TESTING, NULL);

}

@@ -823,11 +823,11 @@ TEST_F(ExtensionMessageBubbleTest, MAYBE_NtpOverriddenControllerTest) {

// Clean up after ourselves.

service_->UninstallExtension(

- kId1, ExtensionService::UNINSTALL_REASON_FOR_TESTING, NULL);

+ kId1, UninstalledExtensionInfo::REASON_FOR_TESTING, NULL);

service_->UninstallExtension(

- kId2, ExtensionService::UNINSTALL_REASON_FOR_TESTING, NULL);

+ kId2, UninstalledExtensionInfo::REASON_FOR_TESTING, NULL);

service_->UninstallExtension(

- kId3, ExtensionService::UNINSTALL_REASON_FOR_TESTING, NULL);

+ kId3, UninstalledExtensionInfo::REASON_FOR_TESTING, NULL);

}

void SetInstallTime(const std::string& extension_id,

@@ -946,11 +946,11 @@ TEST_F(ExtensionMessageBubbleTest, MAYBE_ProxyOverriddenControllerTest) {

// Clean up after ourselves.

service_->UninstallExtension(

- kId1, ExtensionService::UNINSTALL_REASON_FOR_TESTING, NULL);

+ kId1, UninstalledExtensionInfo::REASON_FOR_TESTING, NULL);

service_->UninstallExtension(

- kId2, ExtensionService::UNINSTALL_REASON_FOR_TESTING, NULL);

+ kId2, UninstalledExtensionInfo::REASON_FOR_TESTING, NULL);

service_->UninstallExtension(

- kId3, ExtensionService::UNINSTALL_REASON_FOR_TESTING, NULL);

+ kId3, UninstalledExtensionInfo::REASON_FOR_TESTING, NULL);

}

} // namespace extensions