chrome/browser/extensions/api/management/management_api.cc - Issue 398083002: Add "UninstallReason" parameter to ExtensionRegistryObserver::OnExtensionUninstalled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/management/management_api.cc

Issue 398083002: Add "UninstallReason" parameter to ExtensionRegistryObserver::OnExtensionUninstalled. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chrome_notification_types.h ('K') | « chrome/browser/extensions/activity_log/activity_log_enabled_unittest.cc ('k') | chrome/browser/extensions/extension_browsertest.cc » ('j') | chrome/browser/extensions/extension_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/management/management_api.cc

diff --git a/chrome/browser/extensions/api/management/management_api.cc b/chrome/browser/extensions/api/management/management_api.cc

index a23288f54367e9e85692a3951bdb0271ca9ccdee..7206162c440d85ce00912d1873927b359fe097a6 100644

--- a/chrome/browser/extensions/api/management/management_api.cc

+++ b/chrome/browser/extensions/api/management/management_api.cc

@@ -647,9 +647,7 @@ void ManagementUninstallFunctionBase::Finish(bool should_uninstall) {

SendResponse(false);

} else {

bool success = service()->UninstallExtension(

- extension_id_,

- ExtensionService::UNINSTALL_REASON_MANAGEMENT_API,

- NULL);

+ extension_id_, UninstalledExtensionInfo::REASON_MANAGEMENT_API, NULL);

// TODO set error_ if !success

SendResponse(success);