chrome/browser/apps/ephemeral_app_browsertest.cc - Issue 398083002: Add "UninstallReason" parameter to ExtensionRegistryObserver::OnExtensionUninstalled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/apps/ephemeral_app_browsertest.cc

Issue 398083002: Add "UninstallReason" parameter to ExtensionRegistryObserver::OnExtensionUninstalled. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/apps/drive/drive_app_provider.cc ('k') | chrome/browser/apps/ephemeral_app_service.cc » ('j') | chrome/browser/chrome_notification_types.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/apps/ephemeral_app_browsertest.cc

diff --git a/chrome/browser/apps/ephemeral_app_browsertest.cc b/chrome/browser/apps/ephemeral_app_browsertest.cc

index 869512a671cf5482437c1372ca06035e299f9362..e3a96f2bbf8fee96af813a7b46c66751cdf98cbf 100644

--- a/chrome/browser/apps/ephemeral_app_browsertest.cc

+++ b/chrome/browser/apps/ephemeral_app_browsertest.cc

@@ -48,6 +48,7 @@ using extensions::ExtensionRegistry;

using extensions::ExtensionRegistryObserver;

using extensions::ExtensionSystem;

using extensions::Manifest;

+using extensions::UninstalledExtensionInfo;

namespace {

@@ -244,7 +245,7 @@ void EphemeralAppTestBase::EvictApp(const std::string& app_id) {

ASSERT_TRUE(service);

service->UninstallExtension(

app_id,

- ExtensionService::UNINSTALL_REASON_ORPHANED_EPHEMERAL_EXTENSION,

+ UninstalledExtensionInfo::REASON_ORPHANED_EPHEMERAL_EXTENSION,

NULL);

uninstalled_signal.Wait();