Add "UninstallReason" parameter to ExtensionRegistryObserver::OnExtensionUninstalled.

chrome/browser/chrome_notification_types.h

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROME_NOTIFICATION_TYPES_H_
 #define CHROME_BROWSER_CHROME_NOTIFICATION_TYPES_H_
 
 #include "build/build_config.h"
 #include "content/public/browser/notification_types.h"
 
@@ skipping 400 matching lines @@
   // extensions are updated. The details are an InstalledExtensionInfo, and the
   // source is a Profile.
   NOTIFICATION_EXTENSION_WILL_BE_INSTALLED_DEPRECATED,
 
   // An error occured during extension install. The details are a string with
   // details about why the install failed.
   NOTIFICATION_EXTENSION_INSTALL_ERROR,
 
   // DEPRECATED: Use ExtensionRegistry::AddObserver instead.
   //
-  // Sent when an extension has been uninstalled. The details are an Extension,
-  // and the source is a Profile.
+  // Sent when an extension has been uninstalled. The details are an
+  // UnloadedExtensionInfo, and the source is a Profile.

[Devlin, 2014/07/16 20:05:43]

Is there a reason we need to include the type with the notification?  It doesn't
look like any of the current clients need it...

[rpaquay, 2014/07/16 21:16:45]

The next CL will have a change to use "reason" from within one of the observers
(in extensions/browser/api/runtime_api.cc).

That said, there is a typo in the comment above (should be
"UninstalledExtensionInfo") that I am fixing in the next patchset.

[Devlin, 2014/07/16 21:29:38]

Hmm... I'm concerned about updating a deprecated notification.  It'll just make
the transition to ExtensionRegistryObserver that much harder.  Perhaps it would
be better to modify ExtensionRegistryObserver::OnExtensionUninstalled, and
update RuntimeAPI to use that instead?

[rpaquay, 2014/07/16 22:14:35]

hmmkay, that can be done. Where do you suggest I move the "UninstallReason" enum
definition (I was trying to follow the same pattern as UnloadedExtensionInfo)?

* If I leave in ExtensionService, it creates a strong dependency with
ExtensionRegistry
* If I create UninstalledExtensionInfo similar to UnloadeExtensionInfo, that new
type is not used anywhere (I am assuming
ExtensionRegistryObserver::OnExtensionUninstalled will follow the same pattern
as ExtensionRegistryObserver::OnExtensionUnloaded).

[Devlin, 2014/07/16 22:17:30]

I would actually say let's put it in its own file
(extensions/common/uninstall_reason.h).  It'll be used enough that it makes
sense, and that way people know where to look. ;)

[rpaquay, 2014/07/16 23:45:16]

Done.

   NOTIFICATION_EXTENSION_UNINSTALLED_DEPRECATED,
 
   // Sent when an extension uninstall is not allowed because the extension is
   // not user manageable.  The details are an Extension, and the source is a
   // Profile.
   NOTIFICATION_EXTENSION_UNINSTALL_NOT_ALLOWED,
 
   // DEPRECATED: Use ExtensionRegistry::AddObserver instead.
   //
   // Sent when an extension is unloaded. This happens when an extension is
@@ skipping 487 matching lines @@
   // Note:-
   // Currently only Content and Chrome define and use notifications.
   // Custom notifications not belonging to Content and Chrome should start
   // from here.
   NOTIFICATION_CHROME_END,
 };
 
 }  // namespace chrome
 
 #endif  // CHROME_BROWSER_CHROME_NOTIFICATION_TYPES_H_