Correct when bubble_shown should be recorded

Correct when user_already_opted_in should be recorded

BUG=377813
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283848

[yao, 2014-07-16 22:39:29]

Please take a look. 

I think the weird value I see is because the user_already_opted_in value is
recorded too early.

[jwd, 2014-07-17 13:49:50]

lgtm

[yao, 2014-07-17 13:51:04]

The CQ bit was checked by yiyaoliu@chromium.org

[commit-bot: I haz the power, 2014-07-17 13:51:59]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/yiyaoliu@chromium.org/398073003/1

[Alexei Svitkine (slow), 2014-07-17 15:15:36]

Hmm, I'm not sure I understand the context here. Why would recording the
histogram at a different time matter? Or perhaps I'm missing something..

https://codereview.chromium.org/398073003/diff/1/chrome/browser/ui/views/sess...
File chrome/browser/ui/views/session_crashed_bubble_view.cc (right):

https://codereview.chromium.org/398073003/diff/1/chrome/browser/ui/views/sess...
chrome/browser/ui/views/session_crashed_bubble_view.cc:163: if
(!uma_opted_in_already)
Nit: Add {}'s.

[yao, 2014-07-17 15:17:16]

The CQ bit was unchecked by yiyaoliu@chromium.org

[yao, 2014-07-17 15:41:22]

+Mike for owner's review, thanks. 

@asvitkine
It doesn't make a big difference. I think it's more reasonable to record that
"user has opted in already" only when the bubble is correctly shown. (Currently,
the user can report "opted in already" with or without the bubble shown.) But
yea, it's both OK.

https://codereview.chromium.org/398073003/diff/1/chrome/browser/ui/views/sess...
File chrome/browser/ui/views/session_crashed_bubble_view.cc (right):

https://codereview.chromium.org/398073003/diff/1/chrome/browser/ui/views/sess...
chrome/browser/ui/views/session_crashed_bubble_view.cc:163: if
(!uma_opted_in_already)
On 2014/07/17 15:15:36, Alexei Svitkine wrote:
> Nit: Add {}'s.

Done.

[Alexei Svitkine (slow), 2014-07-17 15:46:04]

lgtm

[msw, 2014-07-17 17:21:32]

lgtm

[yao, 2014-07-17 17:26:37]

The CQ bit was checked by yiyaoliu@chromium.org

[commit-bot: I haz the power, 2014-07-17 17:28:32]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/yiyaoliu@chromium.org/398073003/20001

[commit-bot: I haz the power, 2014-07-17 20:10:45]

Change committed as 283848