src/ia32/builtins-ia32.cc - Issue 398053002: Introduce FLAG_vector_ics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/builtins-ia32.cc

Issue 398053002: Introduce FLAG_vector_ics. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Register passed in hydrogen, fixed some test failures. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ia32/builtins-ia32.cc

diff --git a/src/ia32/builtins-ia32.cc b/src/ia32/builtins-ia32.cc

index 0a1c0a5e6e4b92455c8f8186f735dcc939243291..0e2f233150e99c7840654780870209c0d0940554 100644

--- a/src/ia32/builtins-ia32.cc

+++ b/src/ia32/builtins-ia32.cc

@@ -1003,6 +1003,9 @@ void Builtins::Generate_FunctionApply(MacroAssembler* masm) {

__ mov(receiver, Operand(ebp, kArgumentsOffset)); // load arguments

// Use inline caching to speed up access to arguments.

+ if (FLAG_vector_ics) {

+ __ mov(LoadIC::SlotRegister(), Immediate(Smi::FromInt(0)));

+ }

Handle<Code> ic = masm->isolate()->builtins()->KeyedLoadIC_Initialize();

__ call(ic, RelocInfo::CODE_TARGET);

// It is important that we do not have a test instruction after the