Index: src/arm/full-codegen-arm.cc |
diff --git a/src/arm/full-codegen-arm.cc b/src/arm/full-codegen-arm.cc |
index 659687bcb7151b41e22b09aab9eeb1efbff11b3b..d8bd27fbd4b275b9d02e3d9a35412d8108b6d7a3 100644 |
--- a/src/arm/full-codegen-arm.cc |
+++ b/src/arm/full-codegen-arm.cc |
@@ -1355,7 +1355,7 @@ void FullCodeGenerator::VisitVariableProxy(VariableProxy* expr) { |
} |
-void FullCodeGenerator::EmitLoadGlobalCheckExtensions(Variable* var, |
+void FullCodeGenerator::EmitLoadGlobalCheckExtensions(VariableProxy* proxy, |
TypeofState typeof_state, |
Label* slow) { |
Register current = cp; |
@@ -1404,7 +1404,12 @@ void FullCodeGenerator::EmitLoadGlobalCheckExtensions(Variable* var, |
} |
__ ldr(LoadIC::ReceiverRegister(), GlobalObjectOperand()); |
- __ mov(LoadIC::NameRegister(), Operand(var->name())); |
+ __ mov(LoadIC::NameRegister(), Operand(proxy->var()->name())); |
+ if (FLAG_vector_ics) { |
+ __ mov(LoadIC::SlotRegister(), |
+ Operand(Smi::FromInt(proxy->VariableFeedbackSlot()))); |
+ } |
+ |
ContextualMode mode = (typeof_state == INSIDE_TYPEOF) |
? NOT_CONTEXTUAL |
: CONTEXTUAL; |
@@ -1444,7 +1449,7 @@ MemOperand FullCodeGenerator::ContextSlotOperandCheckExtensions(Variable* var, |
} |
-void FullCodeGenerator::EmitDynamicLookupFastCase(Variable* var, |
+void FullCodeGenerator::EmitDynamicLookupFastCase(VariableProxy* proxy, |
TypeofState typeof_state, |
Label* slow, |
Label* done) { |
@@ -1453,8 +1458,9 @@ void FullCodeGenerator::EmitDynamicLookupFastCase(Variable* var, |
// introducing variables. In those cases, we do not want to |
// perform a runtime call for all variables in the scope |
// containing the eval. |
+ Variable* var = proxy->var(); |
if (var->mode() == DYNAMIC_GLOBAL) { |
- EmitLoadGlobalCheckExtensions(var, typeof_state, slow); |
+ EmitLoadGlobalCheckExtensions(proxy, typeof_state, slow); |
__ jmp(done); |
} else if (var->mode() == DYNAMIC_LOCAL) { |
Variable* local = var->local_if_not_shadowed(); |
@@ -1488,6 +1494,10 @@ void FullCodeGenerator::EmitVariableLoad(VariableProxy* proxy) { |
Comment cmnt(masm_, "[ Global variable"); |
__ ldr(LoadIC::ReceiverRegister(), GlobalObjectOperand()); |
__ mov(LoadIC::NameRegister(), Operand(var->name())); |
+ if (FLAG_vector_ics) { |
+ __ mov(LoadIC::SlotRegister(), |
+ Operand(Smi::FromInt(proxy->VariableFeedbackSlot()))); |
+ } |
CallLoadIC(CONTEXTUAL); |
context()->Plug(r0); |
break; |
@@ -1564,7 +1574,7 @@ void FullCodeGenerator::EmitVariableLoad(VariableProxy* proxy) { |
Label done, slow; |
// Generate code for loading from variables potentially shadowed |
// by eval-introduced variables. |
- EmitDynamicLookupFastCase(var, NOT_INSIDE_TYPEOF, &slow, &done); |
+ EmitDynamicLookupFastCase(proxy, NOT_INSIDE_TYPEOF, &slow, &done); |
__ bind(&slow); |
__ mov(r1, Operand(var->name())); |
__ Push(cp, r1); // Context and name. |
@@ -2078,6 +2088,10 @@ void FullCodeGenerator::VisitYield(Yield* expr) { |
__ bind(&l_call); |
__ ldr(load_receiver, MemOperand(sp, kPointerSize)); |
__ ldr(load_name, MemOperand(sp, 2 * kPointerSize)); |
+ if (FLAG_vector_ics) { |
+ __ mov(LoadIC::SlotRegister(), |
+ Operand(Smi::FromInt(expr->KeyedLoadFeedbackSlot()))); |
+ } |
Handle<Code> ic = isolate()->builtins()->KeyedLoadIC_Initialize(); |
CallIC(ic, TypeFeedbackId::None()); |
__ mov(r1, r0); |
@@ -2094,6 +2108,10 @@ void FullCodeGenerator::VisitYield(Yield* expr) { |
__ push(load_receiver); // save result |
__ LoadRoot(load_name, Heap::kdone_stringRootIndex); // "done" |
+ if (FLAG_vector_ics) { |
+ __ mov(LoadIC::SlotRegister(), |
+ Operand(Smi::FromInt(expr->DoneFeedbackSlot()))); |
+ } |
CallLoadIC(NOT_CONTEXTUAL); // r0=result.done |
Handle<Code> bool_ic = ToBooleanStub::GetUninitialized(isolate()); |
CallIC(bool_ic); |
@@ -2103,6 +2121,10 @@ void FullCodeGenerator::VisitYield(Yield* expr) { |
// result.value |
__ pop(load_receiver); // result |
__ LoadRoot(load_name, Heap::kvalue_stringRootIndex); // "value" |
+ if (FLAG_vector_ics) { |
+ __ mov(LoadIC::SlotRegister(), |
+ Operand(Smi::FromInt(expr->ValueFeedbackSlot()))); |
+ } |
CallLoadIC(NOT_CONTEXTUAL); // r0=result.value |
context()->DropAndPlug(2, r0); // drop iter and g |
break; |
@@ -2278,16 +2300,26 @@ void FullCodeGenerator::EmitNamedPropertyLoad(Property* prop) { |
SetSourcePosition(prop->position()); |
Literal* key = prop->key()->AsLiteral(); |
__ mov(LoadIC::NameRegister(), Operand(key->value())); |
- // Call load IC. It has register arguments receiver and property. |
- CallLoadIC(NOT_CONTEXTUAL, prop->PropertyFeedbackId()); |
+ if (FLAG_vector_ics) { |
+ __ mov(LoadIC::SlotRegister(), |
+ Operand(Smi::FromInt(prop->PropertyFeedbackSlot()))); |
+ CallLoadIC(NOT_CONTEXTUAL); |
+ } else { |
+ CallLoadIC(NOT_CONTEXTUAL, prop->PropertyFeedbackId()); |
+ } |
} |
void FullCodeGenerator::EmitKeyedPropertyLoad(Property* prop) { |
SetSourcePosition(prop->position()); |
- // Call keyed load IC. It has register arguments receiver and key. |
Handle<Code> ic = isolate()->builtins()->KeyedLoadIC_Initialize(); |
- CallIC(ic, prop->PropertyFeedbackId()); |
+ if (FLAG_vector_ics) { |
+ __ mov(LoadIC::SlotRegister(), |
+ Operand(Smi::FromInt(prop->PropertyFeedbackSlot()))); |
+ CallIC(ic); |
+ } else { |
+ CallIC(ic, prop->PropertyFeedbackId()); |
+ } |
} |
@@ -2761,7 +2793,7 @@ void FullCodeGenerator::VisitCall(Call* expr) { |
{ PreservePositionScope scope(masm()->positions_recorder()); |
// Generate code for loading from variables potentially shadowed |
// by eval-introduced variables. |
- EmitDynamicLookupFastCase(proxy->var(), NOT_INSIDE_TYPEOF, &slow, &done); |
+ EmitDynamicLookupFastCase(proxy, NOT_INSIDE_TYPEOF, &slow, &done); |
} |
__ bind(&slow); |
@@ -4056,7 +4088,13 @@ void FullCodeGenerator::VisitCallRuntime(CallRuntime* expr) { |
// Load the function from the receiver. |
__ mov(LoadIC::NameRegister(), Operand(expr->name())); |
- CallLoadIC(NOT_CONTEXTUAL, expr->CallRuntimeFeedbackId()); |
+ if (FLAG_vector_ics) { |
+ __ mov(LoadIC::SlotRegister(), |
+ Operand(Smi::FromInt(expr->CallRuntimeFeedbackSlot()))); |
+ CallLoadIC(NOT_CONTEXTUAL); |
+ } else { |
+ CallLoadIC(NOT_CONTEXTUAL, expr->CallRuntimeFeedbackId()); |
+ } |
// Push the target function under the receiver. |
__ ldr(ip, MemOperand(sp, 0)); |
@@ -4390,6 +4428,10 @@ void FullCodeGenerator::VisitForTypeofValue(Expression* expr) { |
Comment cmnt(masm_, "[ Global variable"); |
__ ldr(LoadIC::ReceiverRegister(), GlobalObjectOperand()); |
__ mov(LoadIC::NameRegister(), Operand(proxy->name())); |
+ if (FLAG_vector_ics) { |
+ __ mov(LoadIC::SlotRegister(), |
+ Operand(Smi::FromInt(proxy->VariableFeedbackSlot()))); |
+ } |
// Use a regular load, not a contextual load, to avoid a reference |
// error. |
CallLoadIC(NOT_CONTEXTUAL); |
@@ -4401,7 +4443,7 @@ void FullCodeGenerator::VisitForTypeofValue(Expression* expr) { |
// Generate code for loading from variables potentially shadowed |
// by eval-introduced variables. |
- EmitDynamicLookupFastCase(proxy->var(), INSIDE_TYPEOF, &slow, &done); |
+ EmitDynamicLookupFastCase(proxy, INSIDE_TYPEOF, &slow, &done); |
__ bind(&slow); |
__ mov(r0, Operand(proxy->name())); |