Introduce FLAG_vector_ics.

Introduce FLAG_vector_ics.

When FLAG_vector_ics is true, then AST nodes that use Load and KeyedLoad ICs
will allocate a type vector slot to store feedback information. Full codegen
will emit a load of the slot into a register if the flag is on.

Support is incomplete, right now the IC doesn't know how to use the feedback
slot.

R=verwaest@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=22500

[mvstanton, 2014-07-16 16:10:11]

Hi Toon,
This is much of the "basic infrastructure" that needs to be in place. It would
be nice to check this in (on all platforms) after some iterations as a basis for
experiment. Should the experimental feature fail to take off, it would be
removed.
--Michael

[Toon Verwaest, 2014-07-18 09:52:16]

Looks good, go ahead and port.

https://codereview.chromium.org/398053002/diff/60001/src/ast.cc
File src/ast.cc (right):

https://codereview.chromium.org/398053002/diff/60001/src/ast.cc#newcode1104
src/ast.cc:1104: DONT_OPTIMIZE_NODE_WITH_FEEDBACK_SLOTS(Yield)
Some sorting would be nice...

https://codereview.chromium.org/398053002/diff/60001/src/flag-definitions.h
File src/flag-definitions.h (right):

https://codereview.chromium.org/398053002/diff/60001/src/flag-definitions.h#n...
src/flag-definitions.h:219: DEFINE_bool(vector_ics, true, "support vector-based
ics")
false?

https://codereview.chromium.org/398053002/diff/60001/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):

https://codereview.chromium.org/398053002/diff/60001/src/hydrogen-instruction...
src/hydrogen-instructions.h:5409: ASSERT(FLAG_vector_ics && slot_ != -1);
!= kInvalidFeedbackSlot

https://codereview.chromium.org/398053002/diff/60001/src/hydrogen-instruction...
src/hydrogen-instructions.h:5432: slot_(-1) {
kInvalidFeedbackSlot

https://codereview.chromium.org/398053002/diff/60001/src/hydrogen-instruction...
src/hydrogen-instructions.h:6409: ASSERT(FLAG_vector_ics && slot_ != -1);
kInvalidFeedbackSlot

https://codereview.chromium.org/398053002/diff/60001/src/hydrogen-instruction...
src/hydrogen-instructions.h:6428: slot_(-1) {
kInvalidFeedbackSlot

[mvstanton, 2014-07-18 13:35:05]

Thanks Toon, ports addressed.
--Michael

https://codereview.chromium.org/398053002/diff/60001/src/ast.cc
File src/ast.cc (right):

https://codereview.chromium.org/398053002/diff/60001/src/ast.cc#newcode1104
src/ast.cc:1104: DONT_OPTIMIZE_NODE_WITH_FEEDBACK_SLOTS(Yield)
On 2014/07/18 09:52:16, Toon Verwaest wrote:
> Some sorting would be nice...

Done.

https://codereview.chromium.org/398053002/diff/60001/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):

https://codereview.chromium.org/398053002/diff/60001/src/hydrogen-instruction...
src/hydrogen-instructions.h:5409: ASSERT(FLAG_vector_ics && slot_ != -1);
On 2014/07/18 09:52:16, Toon Verwaest wrote:
> != kInvalidFeedbackSlot

Done.

https://codereview.chromium.org/398053002/diff/60001/src/hydrogen-instruction...
src/hydrogen-instructions.h:5432: slot_(-1) {
On 2014/07/18 09:52:16, Toon Verwaest wrote:
> kInvalidFeedbackSlot

Done.

https://codereview.chromium.org/398053002/diff/60001/src/hydrogen-instruction...
src/hydrogen-instructions.h:6409: ASSERT(FLAG_vector_ics && slot_ != -1);
On 2014/07/18 09:52:16, Toon Verwaest wrote:
> kInvalidFeedbackSlot

Done.

https://codereview.chromium.org/398053002/diff/60001/src/hydrogen-instruction...
src/hydrogen-instructions.h:6428: slot_(-1) {
On 2014/07/18 09:52:16, Toon Verwaest wrote:
> kInvalidFeedbackSlot

Done.

[Toon Verwaest, 2014-07-21 09:04:36]

lgtm

[mvstanton, 2014-07-21 11:20:16]

Committed patchset #6 manually as r22500.