Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 398043003: Make Rappor enabled by default. (Closed)

Created:
6 years, 5 months ago by Steven Holte
Modified:
6 years, 5 months ago
CC:
chromium-reviews, Ilya Sherman, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Make Rappor enabled by default. BUG=334889 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285483

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M components/rappor/rappor_service.cc View 1 2 1 chunk +9 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Steven Holte
6 years, 5 months ago (2014-07-23 20:59:33 UTC) #1
Alexei Svitkine (slow)
lgtm https://codereview.chromium.org/398043003/diff/20001/components/rappor/rappor_service.cc File components/rappor/rappor_service.cc (right): https://codereview.chromium.org/398043003/diff/20001/components/rappor/rappor_service.cc#newcode45 components/rappor/rappor_service.cc:45: if (server_url.size()) Nit: ! .empty()
6 years, 5 months ago (2014-07-23 21:11:52 UTC) #2
Steven Holte
https://codereview.chromium.org/398043003/diff/20001/components/rappor/rappor_service.cc File components/rappor/rappor_service.cc (right): https://codereview.chromium.org/398043003/diff/20001/components/rappor/rappor_service.cc#newcode45 components/rappor/rappor_service.cc:45: if (server_url.size()) On 2014/07/23 21:11:52, Alexei Svitkine wrote: > ...
6 years, 5 months ago (2014-07-24 21:58:06 UTC) #3
Steven Holte
The CQ bit was checked by holte@chromium.org
6 years, 5 months ago (2014-07-24 21:58:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/holte@chromium.org/398043003/40001
6 years, 5 months ago (2014-07-24 21:59:04 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-25 02:27:43 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 05:26:14 UTC) #7
Message was sent while issue was closed.
Change committed as 285483

Powered by Google App Engine
This is Rietveld 408576698