Issue 398043002: make gm self-tests launch python unittests automatically

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 398043002: make gm self-tests launch python unittests automatically (Closed)

Created:
6 years, 5 months ago by epoger

Modified:
6 years, 5 months ago

Reviewers:
rmistry

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

make gm self-tests launch python unittests automatically (not just within the rebaseline_server subdirectory) Generally useful, but needed asap for my work on http://skbug.com/2752 ('split existing "gpu" GM results into "gl" and "gles"') BUG=skia:677 NOTREECHECKS=True NOTRY=True TBR=rmistry Committed: https://skia.googlesource.com/skia/+/33ac9506fba85373135d78212bdfaab597ba7ed7

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -11 lines)			Patch
A	gm/rebaseline_server/__init__.py	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	gm/rebaseline_server/base_unittest.py	View		2 chunks	+8 lines, -3 lines	0 comments	Download
M	gm/rebaseline_server/test_all.py	View		1 chunk	+0 lines, -3 lines	0 comments	Download
A +	gm/test_all.py	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
M	gm/tests/run.sh	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 6 (0 generated)

epoger

committing TBR, because it will help me move on with the next step. Hope that's ...

6 years, 5 months ago (2014-07-16 15:27:48 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/398043002/20001

6 years, 5 months ago (2014-07-16 15:28:18 UTC) #4

commit-bot: I haz the power

Change committed as 33ac9506fba85373135d78212bdfaab597ba7ed7

6 years, 5 months ago (2014-07-16 15:28:29 UTC) #5

rmistry

6 years, 5 months ago (2014-07-17 11:29:55 UTC) #6

Message was sent while issue was closed.

On 2014/07/16 15:28:29, I haz the power (commit-bot) wrote:
> Change committed as 33ac9506fba85373135d78212bdfaab597ba7ed7

LGTM