Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Side by Side Diff: src/mips/code-stubs-mips.cc

Issue 39803002: Get rid of unused STRING_ADD_ERECT_FRAME flag. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/code-stubs-ia32.cc ('k') | src/x64/code-stubs-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4763 matching lines...) Expand 10 before | Expand all | Expand 10 after
4774 // t2: first character of result. 4774 // t2: first character of result.
4775 StringHelper::GenerateCopyCharacters(masm, t2, t3, a2, t0, false); 4775 StringHelper::GenerateCopyCharacters(masm, t2, t3, a2, t0, false);
4776 // t2: next character of result. 4776 // t2: next character of result.
4777 StringHelper::GenerateCopyCharacters(masm, t2, a1, a3, t0, false); 4777 StringHelper::GenerateCopyCharacters(masm, t2, a1, a3, t0, false);
4778 4778
4779 __ IncrementCounter(counters->string_add_native(), 1, a2, a3); 4779 __ IncrementCounter(counters->string_add_native(), 1, a2, a3);
4780 __ DropAndRet(2); 4780 __ DropAndRet(2);
4781 4781
4782 // Just jump to runtime to add the two strings. 4782 // Just jump to runtime to add the two strings.
4783 __ bind(&call_runtime); 4783 __ bind(&call_runtime);
4784 if ((flags_ & STRING_ADD_ERECT_FRAME) != 0) { 4784 __ TailCallRuntime(Runtime::kStringAdd, 2, 1);
4785 GenerateRegisterArgsPop(masm);
4786 // Build a frame.
4787 {
4788 FrameScope scope(masm, StackFrame::INTERNAL);
4789 GenerateRegisterArgsPush(masm);
4790 __ CallRuntime(Runtime::kStringAdd, 2);
4791 }
4792 __ Ret();
4793 } else {
4794 __ TailCallRuntime(Runtime::kStringAdd, 2, 1);
4795 }
4796 4785
4797 if (call_builtin.is_linked()) { 4786 if (call_builtin.is_linked()) {
4798 __ bind(&call_builtin); 4787 __ bind(&call_builtin);
4799 if ((flags_ & STRING_ADD_ERECT_FRAME) != 0) { 4788 __ InvokeBuiltin(builtin_id, JUMP_FUNCTION);
4800 GenerateRegisterArgsPop(masm);
4801 // Build a frame.
4802 {
4803 FrameScope scope(masm, StackFrame::INTERNAL);
4804 GenerateRegisterArgsPush(masm);
4805 __ InvokeBuiltin(builtin_id, CALL_FUNCTION);
4806 }
4807 __ Ret();
4808 } else {
4809 __ InvokeBuiltin(builtin_id, JUMP_FUNCTION);
4810 }
4811 } 4789 }
4812 } 4790 }
4813 4791
4814 4792
4815 void StringAddStub::GenerateRegisterArgsPush(MacroAssembler* masm) { 4793 void StringAddStub::GenerateRegisterArgsPush(MacroAssembler* masm) {
4816 __ push(a0); 4794 __ push(a0);
4817 __ push(a1); 4795 __ push(a1);
4818 } 4796 }
4819 4797
4820 4798
(...skipping 1417 matching lines...) Expand 10 before | Expand all | Expand 10 after
6238 __ bind(&fast_elements_case); 6216 __ bind(&fast_elements_case);
6239 GenerateCase(masm, FAST_ELEMENTS); 6217 GenerateCase(masm, FAST_ELEMENTS);
6240 } 6218 }
6241 6219
6242 6220
6243 #undef __ 6221 #undef __
6244 6222
6245 } } // namespace v8::internal 6223 } } // namespace v8::internal
6246 6224
6247 #endif // V8_TARGET_ARCH_MIPS 6225 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « src/ia32/code-stubs-ia32.cc ('k') | src/x64/code-stubs-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698